Introduce InputWithMessage

InputWithMessage is similar to InputWithCommitMessage but is intended
for messages other than commit messages, i.e. a message added to the
change review history.

We can't simply use the existing InputWithCommitMessage for this since
the message field is named 'commitMessage' and this would be a breaking
API change.

Change-Id: I5383dfc5c2b08e50675daec4a1a07b538d90ae15
This commit is contained in:
David Pursehouse
2019-10-29 14:01:34 +09:00
parent 79a735f44e
commit 236206515a
6 changed files with 53 additions and 25 deletions

View File

@@ -48,6 +48,7 @@ import com.google.gerrit.extensions.common.ChangeMessageInfo;
import com.google.gerrit.extensions.common.CommentInfo;
import com.google.gerrit.extensions.common.CommitMessageInput;
import com.google.gerrit.extensions.common.Input;
import com.google.gerrit.extensions.common.InputWithMessage;
import com.google.gerrit.extensions.common.MergePatchSetInput;
import com.google.gerrit.extensions.common.PureRevertInfo;
import com.google.gerrit.extensions.common.RevertSubmissionInfo;
@@ -63,7 +64,6 @@ import com.google.gerrit.server.StarredChangesUtil;
import com.google.gerrit.server.StarredChangesUtil.IllegalLabelException;
import com.google.gerrit.server.change.ChangeMessageResource;
import com.google.gerrit.server.change.ChangeResource;
import com.google.gerrit.server.change.SetPrivateOp;
import com.google.gerrit.server.change.WorkInProgressOp;
import com.google.gerrit.server.restapi.change.Abandon;
import com.google.gerrit.server.restapi.change.ChangeIncludedIn;
@@ -324,7 +324,7 @@ class ChangeApiImpl implements ChangeApi {
@Override
public void setPrivate(boolean value, @Nullable String message) throws RestApiException {
try {
SetPrivateOp.Input input = new SetPrivateOp.Input(message);
InputWithMessage input = new InputWithMessage(message);
if (value) {
postPrivate.apply(change, input);
} else {