opendev/gerrit
Code Issues Proposed changes

Prevent ctrl-s in comment editors from doing the default in the browser

Browse Source 
The user wants to save the comment, not save the web page.

Signed-off-by: Shawn O. Pearce <sop@google.com>
This commit is contained in:
Shawn O. Pearce
2009-01-15 08:17:02 -08:00
parent ce13ef0c09
commit 23b9473fcf
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
appjar/src/main/java/com/google/gerrit/client/patches/CommentEditorPanel.java
View File

@@ -44,6 +44,7 @@ class CommentEditorPanel extends Composite implements ClickListener {
DOM.eventCancelBubble(DOM.eventGetCurrentEvent(), true); DOM.eventCancelBubble(DOM.eventGetCurrentEvent(), true);
if (kc == KEY_ESCAPE && mod == 0 && isNew()) { if (kc == KEY_ESCAPE && mod == 0 && isNew()) {
DOM.eventPreventDefault(DOM.eventGetCurrentEvent());
onDiscard(); onDiscard();
return; return;
} }
@@ -51,12 +52,14 @@ class CommentEditorPanel extends Composite implements ClickListener {
if ((mod & MODIFIER_CTRL) == MODIFIER_CTRL) { if ((mod & MODIFIER_CTRL) == MODIFIER_CTRL) {
switch (kc) { switch (kc) {
case 's': case 's':
DOM.eventPreventDefault(DOM.eventGetCurrentEvent());
onSave(); onSave();
return; return;
case 'd': case 'd':
case KEY_BACKSPACE: case KEY_BACKSPACE:
case KEY_DELETE: case KEY_DELETE:
DOM.eventPreventDefault(DOM.eventGetCurrentEvent());
if (isNew()) { if (isNew()) {
onDiscard(); onDiscard();
} else if (Window.confirm(PatchUtil.C.confirmDiscard())) { } else if (Window.confirm(PatchUtil.C.confirmDiscard())) {