opendev/gerrit
Code Issues Proposed changes

Miscellaneous Javadoc cleanups to cut down on Eclipse warnings

Browse Source 
Change-Id: Ifd80c546641db979911e3339fa40ab3585ca69a1
This commit is contained in:
Dave Borowitz
2013-10-08 11:06:19 -07:00
parent 6da366f2b3
commit 23da0d9f13
24 changed files with 58 additions and 66 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
gerrit-extension-api/src/main/java/com/google/gerrit/extensions/annotations/RequiresCapability.java
View File

@@ -21,7 +21,8 @@ import java.lang.annotation.Retention;
import java.lang.annotation.Target;
/**
* Annotation on {@link SshCommand} or {@link RestApiServlet} declaring a
* Annotation on {@link com.google.gerrit.sshd.SshCommand} or
* {@link com.google.gerrit.httpd.restapi.RestApiServlet} declaring a
* capability must be granted.
*/
@Target({ElementType.TYPE})

3
gerrit-extension-api/src/main/java/com/google/gerrit/extensions/registration/DynamicMap.java
View File

@@ -17,6 +17,7 @@ package com.google.gerrit.extensions.registration;
import com.google.inject.Binder;
import com.google.inject.Key;
import com.google.inject.Provider;
import com.google.inject.ProvisionException;
import com.google.inject.Scopes;
import com.google.inject.TypeLiteral;
import com.google.inject.util.Types;
@@ -103,7 +104,7 @@ public abstract class DynamicMap<T> implements Iterable<DynamicMap.Entry<T>> {
* @throws ProvisionException if the registered provider is unable to obtain
* an instance of the requested implementation.
*/
public T get(String pluginName, String exportName) {
public T get(String pluginName, String exportName) throws ProvisionException {
Provider<T> p = items.get(new NamePair(pluginName, exportName));
return p != null ? p.get() : null;
}

2
gerrit-extension-api/src/main/java/com/google/gerrit/extensions/registration/PrivateInternals_DynamicMapImpl.java
View File

@@ -51,7 +51,7 @@ public class PrivateInternals_DynamicMapImpl<T> extends DynamicMap<T> {
* @param key unique description from the item's Guice binding. This can be
* later obtained from the registration handle to facilitate matching
* with the new equivalent instance during a hot reload. The key must
* use an {@link @Export} annotation.
* use an {@link Export} annotation.
* @param item the item to add to the collection right now. Must not be null.
* @return a handle that can remove this item later, or hot-swap the item
* without it ever leaving the collection.