opendev/gerrit
Code Issues Proposed changes

Fix: Right border of the expanded lines is missing.

Browse Source 
Expand the lines of context in SideBySide view,
the expanded lines' right border is missing.

This commit fixed it.

Change-Id: I7d2402631fab46af66e5ef498ea1f238f00aed4e
This commit is contained in:
Bruce Zu
2012-10-23 14:51:10 +08:00
parent a784c3da49
commit 23e4cf3eef
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/SideBySideTable.java
View File

@@ -242,6 +242,7 @@ public class SideBySideTable extends AbstractPatchContentTable {
fmt.addStyleName(row, A, Gerrit.RESOURCES.css().diffText()); fmt.addStyleName(row, A, Gerrit.RESOURCES.css().diffText());
fmt.addStyleName(row, B, Gerrit.RESOURCES.css().diffText()); fmt.addStyleName(row, B, Gerrit.RESOURCES.css().diffText());
fmt.addStyleName(row, B + 1, Gerrit.RESOURCES.css().lineNumber()); fmt.addStyleName(row, B + 1, Gerrit.RESOURCES.css().lineNumber());
fmt.addStyleName(row, B + 1, Gerrit.RESOURCES.css().rightmost());
} }
private int finish(final Iterator<PatchLineComment> i, int row, final int col, boolean expandComment) { private int finish(final Iterator<PatchLineComment> i, int row, final int col, boolean expandComment) {
@@ -310,9 +311,7 @@ public class SideBySideTable extends AbstractPatchContentTable {
CellFormatter fmt = table.getCellFormatter(); CellFormatter fmt = table.getCellFormatter();
for (int i = 0 + offset; i < loopTo + offset; i++) { for (int i = 0 + offset; i < loopTo + offset; i++) {
// The overridden version of insertRow adds some css classes we don't insertRow(row + i);
// want.
super.insertRow(row + i);
table.getRowFormatter().setVerticalAlign(row + i, table.getRowFormatter().setVerticalAlign(row + i,
HasVerticalAlignment.ALIGN_TOP); HasVerticalAlignment.ALIGN_TOP);
int lineA = line.getStartA() + i; int lineA = line.getStartA() + i;