opendev/gerrit
Code Issues Proposed changes

Fix RestApi url encode issue

Browse Source 
"encodeQueryString" converts "%20" (space) to "+" which breaks Rest API
calls if the project name contains spaces. Fixed by using
"encodePathSegment" instead.

Change-Id: I049ca6ad54f36f36083222081c731325b5d51b95
This commit is contained in:
sixin li
2016-08-13 06:29:44 +00:00
parent e6bae8ac8c
commit 242ce058a6
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/rpc/RestApi.java
View File

@@ -251,7 +251,7 @@ public class RestApi {
} }
public RestApi id(String id) { public RestApi id(String id) {
return idRaw(URL.encodeQueryString(id)); return idRaw(URL.encodePathSegment(id));
} }
public RestApi id(int id) { public RestApi id(int id) {

2
gerrit-plugin-gwtui/src/main/java/com/google/gerrit/plugin/client/rpc/RestApi.java
View File

@@ -37,7 +37,7 @@ public class RestApi {
} }
public RestApi id(String id) { public RestApi id(String id) {
return idRaw(URL.encodeQueryString(id)); return idRaw(URL.encodePathSegment(id));
} }
public RestApi id(int id) { public RestApi id(int id) {