opendev/gerrit
Code Issues Proposed changes

Delete unused download command general preference

Browse Source 
I cannot find where it is used from the client. Not on gerrit@HEAD and
also not in 2.12 release. I stopped looking at older gerrit releases.

Change-Id: Ied6580b8bb2597561d0c42667db3021a1d32f75e
This commit is contained in:
David Ostrovsky 2019-12-24 08:28:32 +01:00 committed by David Pursehouse
parent f006c3edce
commit 24496644c2
3 changed files with 0 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
Documentation/rest-api-accounts.txt
View File

@ -1252,7 +1252,6 @@ any account.
"changes_per_page": 25,
"show_site_header": true,
"use_flash_clipboard": true,
"download_command": "CHECKOUT",
"date_format": "STD",
"time_format": "HHMM_12",
"diff_view": "SIDE_BY_SIDE",
@ -1309,7 +1308,6 @@ link:#preferences-input[PreferencesInput] entity.
"show_site_header": true,
"use_flash_clipboard": true,
"expand_inline_diffs": true,
"download_command": "CHECKOUT",
"date_format": "STD",
"time_format": "HHMM_12",
"size_bar_in_change_table": true,
@ -1360,7 +1358,6 @@ link:#preferences-info[PreferencesInfo] entity.
"show_site_header": true,
"use_flash_clipboard": true,
"expand_inline_diffs": true,
"download_command": "CHECKOUT",
"date_format": "STD",
"time_format": "HHMM_12",
"size_bar_in_change_table": true,
@ -2715,8 +2712,6 @@ Whether to expand diffs inline instead of opening as separate page
The type of download URL the user prefers to use. May be any key from
the `schemes` map in
link:rest-api-config.html#download-info[DownloadInfo].
|`download_command` ||
The type of download command the user prefers to use.
|`date_format` ||
The format to display the date in.
Allowed values are `STD`, `US`, `ISO`, `EURO`, `UK`.
@ -2784,8 +2779,6 @@ Whether to expand diffs inline instead of opening as separate page
(PolyGerrit only).
|`download_scheme` |optional|
The type of download URL the user prefers to use.
|`download_command` |optional|
The type of download command the user prefers to use.
|`date_format` |optional|
The format to display the date in.
Allowed values are `STD`, `US`, `ISO`, `EURO`, `UK`.

3
java/com/google/gerrit/extensions/client/GeneralPreferencesInfo.java
View File

@ -136,8 +136,6 @@ public class GeneralPreferencesInfo {
public Boolean useFlashClipboard;
/** Type of download URL the user prefers to use. */
public String downloadScheme;
/** Type of download command the user prefers to use. */
public DownloadCommand downloadCommand;
public DateFormat dateFormat;
public TimeFormat timeFormat;
@ -213,7 +211,6 @@ public class GeneralPreferencesInfo {
p.emailFormat = EmailFormat.HTML_PLAINTEXT;
p.reviewCategoryStrategy = ReviewCategoryStrategy.NONE;
p.downloadScheme = null;
p.downloadCommand = DownloadCommand.CHECKOUT;
p.dateFormat = DateFormat.STD;
p.timeFormat = TimeFormat.HHMM_12;
p.expandInlineDiffs = false;

2
javatests/com/google/gerrit/acceptance/api/accounts/GeneralPreferencesIT.java
View File

@ -24,7 +24,6 @@ import com.google.gerrit.extensions.client.GeneralPreferencesInfo;
import com.google.gerrit.extensions.client.GeneralPreferencesInfo.DateFormat;
import com.google.gerrit.extensions.client.GeneralPreferencesInfo.DefaultBase;
import com.google.gerrit.extensions.client.GeneralPreferencesInfo.DiffView;
import com.google.gerrit.extensions.client.GeneralPreferencesInfo.DownloadCommand;
import com.google.gerrit.extensions.client.GeneralPreferencesInfo.EmailFormat;
import com.google.gerrit.extensions.client.GeneralPreferencesInfo.EmailStrategy;
import com.google.gerrit.extensions.client.GeneralPreferencesInfo.ReviewCategoryStrategy;
@ -73,7 +72,6 @@ public class GeneralPreferencesIT extends AbstractDaemonTest {
i.changesPerPage *= -1;
i.showSiteHeader ^= true;
i.useFlashClipboard ^= true;
i.downloadCommand = DownloadCommand.REPO_DOWNLOAD;
i.dateFormat = DateFormat.US;
i.timeFormat = TimeFormat.HHMM_24;
i.emailStrategy = EmailStrategy.DISABLED;