diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/StarredChangesUtil.java b/gerrit-server/src/main/java/com/google/gerrit/server/StarredChangesUtil.java index 651ed2ccfd..071bdb413a 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/StarredChangesUtil.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/StarredChangesUtil.java @@ -319,6 +319,10 @@ public class StarredChangesUtil { return getLabels(accountId, changeId).contains(IGNORE_LABEL); } + public boolean isIgnored(ChangeResource rsrc) throws OrmException { + return isIgnoredBy(rsrc.getChange().getId(), rsrc.getUser().asIdentifiedUser().getAccountId()); + } + private static String getMuteLabel(Change change) { return MUTE_LABEL + "/" + change.currentPatchSetId().get(); } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/change/Ignore.java b/gerrit-server/src/main/java/com/google/gerrit/server/change/Ignore.java index cf05d95d28..f3ccb904a2 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/change/Ignore.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/change/Ignore.java @@ -18,11 +18,9 @@ import com.google.gerrit.extensions.restapi.Response; import com.google.gerrit.extensions.restapi.RestApiException; import com.google.gerrit.extensions.restapi.RestModifyView; import com.google.gerrit.extensions.webui.UiAction; -import com.google.gerrit.server.IdentifiedUser; import com.google.gerrit.server.StarredChangesUtil; import com.google.gwtorm.server.OrmException; import com.google.inject.Inject; -import com.google.inject.Provider; import com.google.inject.Singleton; import org.slf4j.Logger; import org.slf4j.LoggerFactory; @@ -34,12 +32,10 @@ public class Ignore public static class Input {} - private final Provider self; private final StarredChangesUtil stars; @Inject - Ignore(Provider self, StarredChangesUtil stars) { - this.self = self; + Ignore(StarredChangesUtil stars) { this.stars = stars; } @@ -70,7 +66,7 @@ public class Ignore private boolean isIgnored(ChangeResource rsrc) { try { - return stars.isIgnoredBy(rsrc.getChange().getId(), self.get().getAccountId()); + return stars.isIgnored(rsrc); } catch (OrmException e) { log.error("failed to check ignored star", e); } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/change/Unignore.java b/gerrit-server/src/main/java/com/google/gerrit/server/change/Unignore.java index 82e6fe9142..2de33752f3 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/change/Unignore.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/change/Unignore.java @@ -18,11 +18,9 @@ import com.google.gerrit.extensions.restapi.Response; import com.google.gerrit.extensions.restapi.RestApiException; import com.google.gerrit.extensions.restapi.RestModifyView; import com.google.gerrit.extensions.webui.UiAction; -import com.google.gerrit.server.IdentifiedUser; import com.google.gerrit.server.StarredChangesUtil; import com.google.gwtorm.server.OrmException; import com.google.inject.Inject; -import com.google.inject.Provider; import com.google.inject.Singleton; import org.slf4j.Logger; import org.slf4j.LoggerFactory; @@ -34,12 +32,10 @@ public class Unignore public static class Input {} - private final Provider self; private final StarredChangesUtil stars; @Inject - Unignore(Provider self, StarredChangesUtil stars) { - this.self = self; + Unignore(StarredChangesUtil stars) { this.stars = stars; } @@ -70,7 +66,7 @@ public class Unignore private boolean isIgnored(ChangeResource rsrc) { try { - return stars.isIgnoredBy(rsrc.getChange().getId(), self.get().getAccountId()); + return stars.isIgnored(rsrc); } catch (OrmException e) { log.error("failed to check ignored star", e); }