opendev/gerrit
Code Issues Proposed changes

Disable template tests

Browse Source 
Existing template tests doesn't work with Polymer 2 & 3. Temporary
disable them. Later they will be deleted or updated.

Change-Id: Ib000e28841358a96fd0a630fd836687a9271e58c
This commit is contained in:
Dmitrii Filippov
2019-11-15 13:35:22 +01:00
parent 01f2af22af
commit 247ff75e54
2 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
polygerrit-ui/README.md
View File

@@ -184,6 +184,11 @@ npm run polylint
```
## Template Type Safety
> **Warning**: This feature is temporary disabled, because it doesn't work with Polymer 2 and Polymer 3.
Some of the checks are made by polymer linter.
Polymer elements are not type checked against the element definition, making it
trivial to break the display when refactoring or moving code. We now run
additional tests to help ensure that template types are checked.

6
polygerrit-ui/app/template_test.sh
View File

@@ -1,5 +1,11 @@
#!/bin/bash
# TODO(dmfilippov): Update template_test to support Polymer 2/Polymer 3 or delete it completely
# The following line temporary disable template tests. Existing implementation doesn't compatible
# with Polymer 2 & 3 class-based components. Polymer linter makes some checks regarding
# templates and binding, but not all.
exit 0
set -ex
node_bin=$(which node)