Store PatchSetApprovals instead of labels in the index
The goal of storing SubmitRecord.Labels in the index was to render the change table, but that requires both the results of the submit rule evaluator and, in fact, all of the current PatchSetApprovals. Instead, store PatchSetApprovals, which are trivial to find at indexing time. Note that we do not just use the formatted label representation stored in the index because it does not contain all the necessary columns (e.g. timestamp). These may not be strictly speaking required for rendering the change table, but having them set to null in some cases might have caused errors down the line. Delete the old label-based code entirely and change schema v2 rather than revving to v3. This mistake was short-lived enough that we don't expect people to have production data using it, and the old code was sufficiently complex and incorrect that keeping it around isn't a good idea. Change-Id: I805a8fd6c60d4818910aed299260f56ef3006287
This commit is contained in:
@@ -21,7 +21,7 @@ import com.google.inject.Provider;
|
||||
|
||||
import org.eclipse.jgit.lib.Config;
|
||||
|
||||
public class EmailExpanderProvider implements Provider<EmailExpander> {
|
||||
class EmailExpanderProvider implements Provider<EmailExpander> {
|
||||
private final EmailExpander expander;
|
||||
|
||||
@Inject
|
||||
|
Reference in New Issue
Block a user