opendev/gerrit
Code Issues Proposed changes

Annotate abstract test classes with @Ignore

Browse Source 
According to I1a9b6ed53 Buck's test runner doesn't skip abstract
classes, but will if they are annotated as @Ignore.

This may not be true any more; Buck seems to be marking the classes as
NOTESTS.

Mark them as @Ignore anyway, even if it's only as documentation.

Also make classes abstract.

Change-Id: Ifc8deef60037bbf0b446542498ba9055037bf5d9
This commit is contained in:
David Pursehouse
2016-02-24 15:42:56 +09:00
parent f896a3eaa0
commit 2583a1736e
7 changed files with 20 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-server/src/test/java/com/google/gerrit/server/tools/hooks/HookTestCase.java
View File

@@ -60,6 +60,7 @@ import org.eclipse.jgit.junit.LocalDiskRepositoryTestCase;
import org.eclipse.jgit.lib.Repository;
import org.junit.After;
import org.junit.Before;
import org.junit.Ignore;
import java.io.File;
import java.io.FileOutputStream;
@@ -69,6 +70,7 @@ import java.net.URL;
import java.util.List;
import java.util.Map;
@Ignore
public abstract class HookTestCase extends LocalDiskRepositoryTestCase {
protected Repository repository;
private final Map<String, File> hooks = Maps.newTreeMap();