opendev/gerrit
Code Issues Proposed changes

Use dedicated endpoint for commit message retrieval for revisions

Browse Source 
Instead of using GET /changes/<number>/edit:message for both edits and
normal revisions, differentiate on the client side and use dedicated
endpoints.

Change-Id: I7e9786c0b828cca9b0aa76bab43f10d223334d86
This commit is contained in:
David Ostrovsky
2014-12-15 21:18:59 +01:00
committed by David Pursehouse
parent 8ffdfc1243
commit 25ad15e451
4 changed files with 25 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/edit/ChangeEditIT.java
View File

@@ -275,11 +275,19 @@ public class ChangeEditIT extends AbstractDaemonTest {
@Test
public void updateMessageRest() throws Exception {
assertThat(adminSession.get(urlEditMessage()).getStatusCode())
.isEqualTo(SC_NOT_FOUND);
EditMessage.Input in = new EditMessage.Input();
in.message = String.format("New commit message\n\nChange-Id: %s",
change.getKey());
assertThat(adminSession.put(urlEditMessage(), in).getStatusCode())
.isEqualTo(SC_NO_CONTENT);
RestResponse r = adminSession.get(urlEditMessage());
assertThat(adminSession.get(urlEditMessage()).getStatusCode())
.isEqualTo(SC_OK);
String content = r.getEntityContent();
assertThat(StringUtils.newStringUtf8(Base64.decodeBase64(content)))
.isEqualTo(in.message);
Optional<ChangeEdit> edit = editUtil.byChange(change);
assertThat(edit.get().getEditCommit().getFullMessage())
.isEqualTo(in.message);