From 25af226e37a3ae40039cec1b4a2432a76c81d87d Mon Sep 17 00:00:00 2001
From: Becky Siegel <beckysiegel@google.com>
Date: Mon, 11 Dec 2017 13:59:25 -0800
Subject: [PATCH] Prepare for rule (only) editing

As project access gets ready to move away from read only mode, there
will be a few intermediate stages in which some functionality is added.

Rule editing (not adding/removing) is the first step. As some of the
additional functionality's UI had been started, temporary CSS changes
must be made to hide this from the user.

This change has no visible changes to the user at this time, all of the
changes only exist when the project access 'editing' is true.

Bug: Issue 6569
Change-Id: I3f39a6a68f5622a597fc8020bb6e31db2d4f24dd
---
 .../admin/gr-access-section/gr-access-section.html  | 10 ++++++----
 .../elements/admin/gr-permission/gr-permission.html | 13 ++++++++-----
 .../admin/gr-rule-editor/gr-rule-editor.html        |  5 +++--
 3 files changed, 17 insertions(+), 11 deletions(-)

diff --git a/polygerrit-ui/app/elements/admin/gr-access-section/gr-access-section.html b/polygerrit-ui/app/elements/admin/gr-access-section/gr-access-section.html
index 529e14c2af..658fd5865e 100644
--- a/polygerrit-ui/app/elements/admin/gr-access-section/gr-access-section.html
+++ b/polygerrit-ui/app/elements/admin/gr-access-section/gr-access-section.html
@@ -61,12 +61,13 @@ limitations under the License.
       .editContainer {
         display: none;
       }
-      .deleted #deletedContainer,
+      /* TODO @beckysiegel add back when editing allowed */
+      /* .deleted #deletedContainer,
       #mainContainer,
       .editing #addPermission,
       .editing #updateBtns  {
         display: block;
-      }
+      } */
       .editingRef .editContainer {
         display: flex;
       }
@@ -115,7 +116,7 @@ limitations under the License.
           </template>
           <div id="addPermission">
             Add permission:
-            <select id="permissionSelect">
+            <select id="permissionSelect"> -->
               <!-- called with a third parameter so that permissions update
                   after a new section is added. -->
               <template
@@ -125,7 +126,8 @@ limitations under the License.
               </template>
             </select>
             <gr-button id="addBtn" on-tap="_handleAddPermission">Add</gr-button>
-          </div><!-- end addPermission -->
+          </div>
+          <!-- end addPermission -->
         </div><!-- end sectionContent -->
       </div><!-- end mainContainer -->
       <div id="deletedContainer">
diff --git a/polygerrit-ui/app/elements/admin/gr-permission/gr-permission.html b/polygerrit-ui/app/elements/admin/gr-permission/gr-permission.html
index 31171f7c63..c38a62c2cc 100644
--- a/polygerrit-ui/app/elements/admin/gr-permission/gr-permission.html
+++ b/polygerrit-ui/app/elements/admin/gr-permission/gr-permission.html
@@ -46,9 +46,10 @@ limitations under the License.
         border: 1px solid #d1d2d3;
         border-bottom: 0;
       }
-      .editing .rules {
+      /* TODO @beckysiegel add back */
+      /* .editing .rules {
         border-bottom: 1px solid #d1d2d3;
-      }
+      } */
       .title {
         margin-bottom: .3em;
       }
@@ -56,13 +57,14 @@ limitations under the License.
       #removeBtn {
         display: none;
       }
-      .editing #removeBtn {
+      /* TODO @beckysiegel add back */
+      /* .editing #removeBtn {
         display: block;
       }
       .editing #addRule {
         display: block;
         padding: .7em;
-      }
+      } */
       #deletedContainer,
       .deleted #mainContainer {
         display: none;
@@ -105,7 +107,8 @@ limitations under the License.
                 placeholder="Add group"
                 on-commit="_handleAddRuleItem">
             </gr-autocomplete>
-          </div> <!-- end addRule -->
+          </div>
+          <!-- end addRule -->
         </div> <!-- end rules -->
       </div><!-- end mainContainer -->
       <div id="deletedContainer">
diff --git a/polygerrit-ui/app/elements/admin/gr-rule-editor/gr-rule-editor.html b/polygerrit-ui/app/elements/admin/gr-rule-editor/gr-rule-editor.html
index 18612c88da..3c04c5c7b4 100644
--- a/polygerrit-ui/app/elements/admin/gr-rule-editor/gr-rule-editor.html
+++ b/polygerrit-ui/app/elements/admin/gr-rule-editor/gr-rule-editor.html
@@ -35,9 +35,10 @@ limitations under the License.
       .buttons {
         display: none;
       }
-      .editing .buttons {
+      /* TODO @beckysiegel add back */
+      /* .editing .buttons {
         display: flex;
-      }
+      } */
       #options {
         align-items: baseline;
         display: flex;