opendev/gerrit
Code Issues Proposed changes

PolyGerrit: Implement /admin/plugins page

Browse Source 
Bug: Issue 6324
Change-Id: I1d594f4bbe05a6c315661463394e0ce2f57c86d2
This commit is contained in:
Paladox none
2017-05-28 14:48:33 +00:00
parent 9feae8c650
commit 25bd8c9cfe
8 changed files with 219 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

52
polygerrit-ui/app/elements/admin/gr-admin-plugin-list/gr-admin-plugin-list.html Normal file
View File

@@ -0,0 +1,52 @@
<!--
Copyright (C) 2017 The Android Open Source Project
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<link rel="import" href="../../../behaviors/gr-list-view-behavior/gr-list-view-behavior.html">
<link rel="import" href="../../../bower_components/polymer/polymer.html">
<link rel="import" href="../../shared/gr-list-view/gr-styled-table.html">
<link rel="import" href="../../shared/gr-rest-api-interface/gr-rest-api-interface.html">
<link rel="import" href="../../../styles/shared-styles.html">
<dom-module id="gr-admin-plugin-list">
<template>
<style include="shared-styles"></style>
<gr-styled-table>
<table id="list">
<tr class="headerRow">
<th class="name topHeader">Plugin Name</th>
<th class="version topHeader">Version</th>
<th class="status topHeader">Status</th>
</tr>
<tr id="loading" class$="loadingMsg [[computeLoadingClass(_loading)]]">
<td>Loading...</td>
</tr>
<template is="dom-repeat" items="[[_plugins]]"
class$="[[computeLoadingClass(_loading)]]">
<tr class="table">
<td class="name">
<a href$="[[_computePluginUrl(item.index_url)]]">[[item.id]]</a>
</td>
<td class="version">[[item.version]]</td>
<td class="status">[[_status(item)]]</td>
</tr>
</template>
</table>
</gr-styled-table>
<gr-rest-api-interface id="restAPI"></gr-rest-api-interface>
</template>
<script src="gr-admin-plugin-list.js"></script>
</dom-module>

58
polygerrit-ui/app/elements/admin/gr-admin-plugin-list/gr-admin-plugin-list.js Normal file
View File

@@ -0,0 +1,58 @@
// Copyright (C) 2017 The Android Open Source Project
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
(function() {
'use strict';
Polymer({
is: 'gr-admin-plugin-list',
properties: {
_plugins: Array,
_loading: {
type: Boolean,
value: true,
},
},
behaviors: [
Gerrit.ListViewBehavior,
],
ready() {
return this.$.restAPI.getPlugins()
.then(plugins => {
if (!plugins) {
this._plugins = [];
return;
}
this._plugins = Object.keys(plugins)
.map(key => {
const plugin = plugins[key];
plugin.name = key;
return plugin;
});
this._loading = false;
});
},
_status(item) {
return item.disabled === true ? 'Disabled' : 'Enabled';
},
_computePluginUrl(id) {
return this.getUrl('/', id);
},
});
})();

86
polygerrit-ui/app/elements/admin/gr-admin-plugin-list/gr-admin-plugin-list_test.html Normal file
View File

@@ -0,0 +1,86 @@
<!DOCTYPE html>
<!--
Copyright (C) 2017 The Android Open Source Project
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<meta name="viewport" content="width=device-width, minimum-scale=1.0, initial-scale=1.0, user-scalable=yes">
<title>gr-admin-plugin-list</title>
<script src="../../../bower_components/page/page.js"></script>
<script src="../../../bower_components/webcomponentsjs/webcomponents-lite.min.js"></script>
<script src="../../../bower_components/web-component-tester/browser.js"></script>
<link rel="import" href="../../../test/common-test-setup.html"/>
<link rel="import" href="gr-admin-plugin-list.html">
<script>void(0);</script>
<test-fixture id="basic">
<template>
<gr-admin-plugin-list></gr-admin-plugin-list>
</template>
</test-fixture>
<script>
let counter = 0;
const pluginGenerator = () => {
return {
id: `test${++counter}`,
index_url: `plugins/test${counter}/`,
version: '3.0-SNAPSHOT',
disabled: false,
};
};
suite('gr-admin-plugin-list tests', () => {
let element;
let plugins;
let sandbox;
setup(() => {
sandbox = sinon.sandbox.create();
element = fixture('basic');
});
teardown(() => {
sandbox.restore();
});
suite('list with plugins', () => {
setup(done => {
plugins = _.times(26, pluginGenerator);
stub('gr-rest-api-interface', {
getPlugins() {
return Promise.resolve(plugins);
},
});
flush(done);
});
test('test for a test plugin in the list', done => {
element._plugins = plugins;
flush(() => {
assert.equal(element._plugins[2].id, 'test3');
assert.equal(element._plugins[2].index_url, 'plugins/test3/');
assert.equal(element._plugins[2].version, '3.0-SNAPSHOT');
assert.equal(element._plugins[2].disabled, false);
done();
});
});
});
});
</script>

12
polygerrit-ui/app/elements/core/gr-router/gr-router.js
View File

@@ -182,6 +182,18 @@
}; };
}); });
page(/^\/admin\/plugins(\/)?$/, loadUser, data => {
restAPI.getLoggedIn().then(loggedIn => {
if (loggedIn) {
app.params = {
view: 'gr-admin-plugin-list',
};
} else {
page.redirect('/login/' + encodeURIComponent(data.canonicalPath));
}
});
});
page('/admin/(.*)', loadUser, data => { page('/admin/(.*)', loadUser, data => {
restAPI.getLoggedIn().then(loggedIn => { restAPI.getLoggedIn().then(loggedIn => {
if (loggedIn) { if (loggedIn) {

4
polygerrit-ui/app/elements/gr-app.html
View File

@@ -21,6 +21,7 @@ limitations under the License.
<link rel="import" href="./admin/gr-admin-group-list/gr-admin-group-list.html"> <link rel="import" href="./admin/gr-admin-group-list/gr-admin-group-list.html">
<link rel="import" href="./admin/gr-admin-project-list/gr-admin-project-list.html"> <link rel="import" href="./admin/gr-admin-project-list/gr-admin-project-list.html">
<link rel="import" href="./admin/gr-admin-project/gr-admin-project.html"> <link rel="import" href="./admin/gr-admin-project/gr-admin-project.html">
<link rel="import" href="./admin/gr-admin-plugin-list/gr-admin-plugin-list.html">
<link rel="import" href="./admin/gr-admin-view/gr-admin-view.html"> <link rel="import" href="./admin/gr-admin-view/gr-admin-view.html">
<link rel="import" href="./change-list/gr-change-list-view/gr-change-list-view.html"> <link rel="import" href="./change-list/gr-change-list-view/gr-change-list-view.html">
<link rel="import" href="./change-list/gr-dashboard-view/gr-dashboard-view.html"> <link rel="import" href="./change-list/gr-dashboard-view/gr-dashboard-view.html">
@@ -154,6 +155,9 @@ limitations under the License.
<template is="dom-if" if="[[_showAdminProject]]" restamp="true"> <template is="dom-if" if="[[_showAdminProject]]" restamp="true">
<gr-admin-project project="[[params.project]]"></gr-admin-project> <gr-admin-project project="[[params.project]]"></gr-admin-project>
</template> </template>
<template is="dom-if" if="[[_showPluginListView]]" restamp="true">
<gr-admin-plugin-list id="pluginList"></gr-admin-plugin-list>
</template>
<template is="dom-if" if="[[_showAdminView]]" restamp="true"> <template is="dom-if" if="[[_showAdminView]]" restamp="true">
<gr-admin-view path="[[_path]]"></gr-admin-view> <gr-admin-view path="[[_path]]"></gr-admin-view>
</template> </template>

2
polygerrit-ui/app/elements/gr-app.js
View File

@@ -50,6 +50,7 @@
_showSettingsView: Boolean, _showSettingsView: Boolean,
_showProjectListView: Boolean, _showProjectListView: Boolean,
_showAdminProject: Boolean, _showAdminProject: Boolean,
_showPluginListView: Boolean,
_showAdminView: Boolean, _showAdminView: Boolean,
_showCLAView: Boolean, _showCLAView: Boolean,
_viewState: Object, _viewState: Object,
@@ -141,6 +142,7 @@
this.set('_showGroupListView', view === 'gr-admin-group-list'); this.set('_showGroupListView', view === 'gr-admin-group-list');
this.set('_showProjectListView', view === 'gr-admin-project-list'); this.set('_showProjectListView', view === 'gr-admin-project-list');
this.set('_showAdminProject', view === 'gr-admin-project'); this.set('_showAdminProject', view === 'gr-admin-project');
this.set('_showPluginListView', view === 'gr-admin-plugin-list');
this.set('_showAdminView', view === 'gr-admin-view'); this.set('_showAdminView', view === 'gr-admin-view');
this.set('_showCLAView', view === 'gr-cla-view'); this.set('_showCLAView', view === 'gr-cla-view');
if (this.params.justRegistered) { if (this.params.justRegistered) {

4
polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-api-interface.js
View File

@@ -515,6 +515,10 @@
); );
}, },
getPlugins() {
return this._fetchSharedCacheURL('/plugins/?all');
},
getSuggestedGroups(inputVal, opt_n, opt_errFn, opt_ctx) { getSuggestedGroups(inputVal, opt_n, opt_errFn, opt_ctx) {
const params = {s: inputVal}; const params = {s: inputVal};
if (opt_n) { params.n = opt_n; } if (opt_n) { params.n = opt_n; }

1
polygerrit-ui/app/test/index.html
View File

@@ -31,6 +31,7 @@ limitations under the License.
// beginning. // beginning.
'gr-app_test.html', 'gr-app_test.html',
'admin/gr-admin-group-list/gr-admin-group-list_test.html', 'admin/gr-admin-group-list/gr-admin-group-list_test.html',
'admin/gr-admin-plugin-list/gr-admin-plugin-list_test.html',
'admin/gr-admin-project/gr-admin-project_test.html', 'admin/gr-admin-project/gr-admin-project_test.html',
'admin/gr-admin-project-list/gr-admin-project-list_test.html', 'admin/gr-admin-project-list/gr-admin-project-list_test.html',
'change-list/gr-change-list-item/gr-change-list-item_test.html', 'change-list/gr-change-list-item/gr-change-list-item_test.html',