opendev/gerrit
Code Issues Proposed changes

Create a link utility to jump to an account dashboard

Browse Source 
Signed-off-by: Shawn O. Pearce <sop@google.com>
This commit is contained in:
Shawn O. Pearce
2008-12-04 11:43:31 -08:00
parent ea18481c37
commit 25ea21c4f0
4 changed files with 112 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
webapp/src/com/google/gerrit/client/changes/ChangeLink.java
View File

@@ -14,15 +14,12 @@
package com.google.gerrit.client.changes;
import com.google.gerrit.client.Gerrit;
import com.google.gerrit.client.Link;
import com.google.gerrit.client.data.ChangeInfo;
import com.google.gwt.user.client.DOM;
import com.google.gwt.user.client.Event;
import com.google.gwt.user.client.History;
import com.google.gwt.user.client.ui.Hyperlink;
import com.google.gerrit.client.ui.DirectScreenLink;
import com.google.gerrit.client.ui.Screen;
public class ChangeLink extends Hyperlink {
public class ChangeLink extends DirectScreenLink {
private ChangeInfo change;
public ChangeLink(final String text, final ChangeInfo c) {
@@ -31,11 +28,7 @@ public class ChangeLink extends Hyperlink {
}
@Override
public void onBrowserEvent(final Event event) {
if (DOM.eventGetType(event) == Event.ONCLICK) {
History.newItem(getTargetHistoryToken(), false);
Gerrit.display(new ChangeScreen(change));
DOM.eventPreventDefault(event);
}
protected Screen createScreen() {
return new ChangeScreen(change);
}
}

6
webapp/src/com/google/gerrit/client/changes/ChangeTable.java
View File

@@ -17,6 +17,7 @@ package com.google.gerrit.client.changes;
import com.google.gerrit.client.Gerrit;
import com.google.gerrit.client.Link;
import com.google.gerrit.client.SignedInListener;
import com.google.gerrit.client.account.AccountDashboardLink;
import com.google.gerrit.client.data.ChangeInfo;
import com.google.gerrit.client.reviewdb.Change;
import com.google.gerrit.client.rpc.GerritCallback;
@@ -32,7 +33,6 @@ import com.google.gwt.user.client.ui.FlexTable;
import com.google.gwt.user.client.ui.FocusListener;
import com.google.gwt.user.client.ui.FocusPanel;
import com.google.gwt.user.client.ui.HasFocus;
import com.google.gwt.user.client.ui.Hyperlink;
import com.google.gwt.user.client.ui.Image;
import com.google.gwt.user.client.ui.KeyboardListener;
import com.google.gwt.user.client.ui.KeyboardListenerAdapter;
@@ -356,9 +356,7 @@ public class ChangeTable extends Composite implements HasFocus {
s += " (" + c.getStatus().name() + ")";
}
table.setWidget(row, C_SUBJECT, new ChangeLink(s, c));
table.setWidget(row, C_OWNER, new Hyperlink(c.getOwner().getFullName(),
Link.toAccountDashboard(c.getOwner())));
table.setWidget(row, C_OWNER, new AccountDashboardLink(c.getOwner()));
table.setText(row, C_REVIEWERS, "TODO");
table.setText(row, C_PROJECT, c.getProject().getName());
table.setText(row, C_LAST_UPDATE, "TODO");