opendev/gerrit
Code Issues Proposed changes

Merge "Add a 'checks--combined' URL parameter to 'changes' queries"

Browse Source
This commit is contained in:
Alice Kober-Sotzek
2019-05-24 13:11:56 +00:00
committed by Gerrit Code Review
parent 5f44feeabd 7de3d39416
commit 25eb65ae7f
1 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-api-interface.js
View File

@@ -1260,6 +1260,17 @@
O: options, O: options,
S: opt_offset || 0, S: opt_offset || 0,
}; };
// This triggers a CheckChangeInfo entity to be added to the plugins
// list in ChangeInfo, if the checks plugin is installed. Otherwise the
// server will just ignore this.
// TODO(brohlfs): Only add this parameter, if the checks plugin is
// installed. Currently this code may be executed even before the
// /config/server/info response is processed, so having that information
// included in the host page is a blocking requirement for resolving this
// TODO.
params['checks--combined'] = '';
if (opt_changesPerPage) { params.n = opt_changesPerPage; } if (opt_changesPerPage) { params.n = opt_changesPerPage; }
if (opt_query && opt_query.length > 0) { if (opt_query && opt_query.length > 0) {
params.q = opt_query; params.q = opt_query;