opendev/gerrit
Code Issues Proposed changes

Clean up PreviewSubmit and tests

Browse Source 
* Fix Eclipse warnings about unclosed resources and missing case blocks.
* Use Jimfs instead of a real file on the filesystem for storing
  temporary zip files. This is a moderate rewrite to use NIO, because
  ZipFile doesn't support Paths.
* Return ObjectId in the fetchFromBundles map. Using RevObjects after
  the lifetime of their RevWalks can lead to difficult-to-debug errors,
  and in this case we don't need anything but the ID.
* Rename assertRevTrees to assertTrees, since it no longer refers to
  RevTrees.
* Add convenience method to run SubmitPreview in a try-with-resources
  block and return the Map result.
* Run google-java-format over all affected files.

Change-Id: I251f390f81cb3372e5b3243d6fbe7e2365bd2dcb
This commit is contained in:
Dave Borowitz
2017-02-22 11:27:49 -05:00
parent 0fed7e848b
commit 262857f297
7 changed files with 103 additions and 103 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
gerrit-acceptance-tests/BUILD
View File

@@ -27,6 +27,7 @@ java_library(
"//lib:gwtjsonrpc",
"//lib:gwtorm",
"//lib:h2",
"//lib:jimfs",
"//lib:jsch",
"//lib:servlet-api-3_1-without-neverlink",
"//lib/bouncycastle:bcpg",