opendev/gerrit
Code Issues Proposed changes

Make ChangeHooks expose postEvent method to send stream event

Browse Source 
Add method ChangeHooks.postEvent(), plugins can now easily send a
stream event, for example, in replication plugin, after a patchset
is replicated, it can send a patchset replicated event.

Change-Id: Ie66497ae8fd9e8ede540754719c3f71fa85bf81a
Signed-off-by: David Pursehouse <david.pursehouse@sonymobile.com>
This commit is contained in:
Yang Zhenhui
2013-07-30 16:59:58 +08:00
committed by David Pursehouse
parent 2a568add87
commit 2659d42198
4 changed files with 55 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
gerrit-server/src/main/java/com/google/gerrit/common/ChangeHookRunner.java
View File

@@ -600,6 +600,18 @@ public class ChangeHookRunner implements ChangeHooks, LifecycleListener {
}
}
@Override
public void postEvent(final Change change, final ChangeEvent event,
final ReviewDb db) throws OrmException {
fireEvent(change, event, db);
}
@Override
public void postEvent(final Branch.NameKey branchName,
final ChangeEvent event) throws OrmException {
fireEvent(branchName, event);
}
private void fireEventForUnrestrictedListeners(final ChangeEvent event) {
for (ChangeListener listener : unrestrictedListeners) {
listener.onChangeEvent(event);

22
gerrit-server/src/main/java/com/google/gerrit/common/ChangeHooks.java
View File

@@ -23,6 +23,7 @@ import com.google.gerrit.reviewdb.client.PatchSet;
import com.google.gerrit.reviewdb.client.Project;
import com.google.gerrit.reviewdb.server.ReviewDb;
import com.google.gerrit.server.IdentifiedUser;
import com.google.gerrit.server.events.ChangeEvent;
import com.google.gwtorm.server.OrmException;
import org.eclipse.jgit.lib.ObjectId;
@@ -170,4 +171,25 @@ public interface ChangeHooks {
*/
public HookResult doRefUpdateHook(Project project, String refName,
Account uploader, ObjectId oldId, ObjectId newId);
/**
* Post a stream event that is related to a change
*
* @param change The change that the event is related to
* @param event The event to post
* @param db The database
* @throws OrmException
*/
public void postEvent(Change change, ChangeEvent event, ReviewDb db)
throws OrmException;
/**
* Post a stream event that is related to a branch
*
* @param branchName The branch that the event is related to
* @param event The event to post
* @throws OrmException
*/
public void postEvent(Branch.NameKey branchName, ChangeEvent event)
throws OrmException;
}

10
gerrit-server/src/main/java/com/google/gerrit/common/DisabledChangeHooks.java
View File

@@ -18,11 +18,13 @@ import com.google.gerrit.common.ChangeHookRunner.HookResult;
import com.google.gerrit.common.data.ContributorAgreement;
import com.google.gerrit.reviewdb.client.Account;
import com.google.gerrit.reviewdb.client.Branch.NameKey;
import com.google.gerrit.reviewdb.client.Branch;
import com.google.gerrit.reviewdb.client.Change;
import com.google.gerrit.reviewdb.client.PatchSet;
import com.google.gerrit.reviewdb.client.Project;
import com.google.gerrit.reviewdb.server.ReviewDb;
import com.google.gerrit.server.IdentifiedUser;
import com.google.gerrit.server.events.ChangeEvent;
import org.eclipse.jgit.lib.ObjectId;
import org.eclipse.jgit.lib.RefUpdate;
@@ -104,4 +106,12 @@ public final class DisabledChangeHooks implements ChangeHooks {
Account uploader, ObjectId oldId, ObjectId newId) {
return null;
}
@Override
public void postEvent(Change change, ChangeEvent event, ReviewDb db) {
}
@Override
public void postEvent(Branch.NameKey branchName, ChangeEvent event) {
}
}