opendev/gerrit
Code Issues Proposed changes

Disallow searching for label:SUBM

Browse Source 
This leaks an internal implementation detail; SUBM is not a real
label.

Strictly speaking we should bump the schema version for this change,
but considering how corner of a case this is, that is far more effort
than it's worth.

Change-Id: I0cba6d3dc661803a22308fc91cc758faa90df4eb
This commit is contained in:
Dave Borowitz
2014-01-03 15:25:55 -08:00
parent f9ae78e51a
commit 267047effa
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-server/src/main/java/com/google/gerrit/server/index/ChangeField.java
View File

@@ -264,7 +264,7 @@ public class ChangeField {
Set<String> allApprovals = Sets.newHashSet(); Set<String> allApprovals = Sets.newHashSet();
Set<String> distinctApprovals = Sets.newHashSet(); Set<String> distinctApprovals = Sets.newHashSet();
for (PatchSetApproval a : input.currentApprovals()) { for (PatchSetApproval a : input.currentApprovals()) {
if (a.getValue() != 0) { if (a.getValue() != 0 && !a.isSubmit()) {
allApprovals.add(formatLabel(a.getLabel(), a.getValue(), allApprovals.add(formatLabel(a.getLabel(), a.getValue(),
a.getAccountId())); a.getAccountId()));
distinctApprovals.add(formatLabel(a.getLabel(), a.getValue())); distinctApprovals.add(formatLabel(a.getLabel(), a.getValue()));