Merge "Remove unused change.largeChange config parameter"
This commit is contained in:
@@ -1319,17 +1319,6 @@ assignee are enabled.
|
||||
+
|
||||
The default is false.
|
||||
|
||||
[[change.largeChange]]change.largeChange::
|
||||
+
|
||||
Number of changed lines from which on a change is considered as a large
|
||||
change. The number of changed lines of a change is the sum of the lines
|
||||
that were inserted and deleted in the change.
|
||||
+
|
||||
The specified value is used to visualize the change sizes in the Web UI
|
||||
in change tables and user dashboards.
|
||||
+
|
||||
By default 500.
|
||||
|
||||
[[change.maxComments]]change.maxComments::
|
||||
+
|
||||
Maximum number of comments (regular plus robot) allowed per change. Additional
|
||||
|
@@ -1552,9 +1552,6 @@ section.
|
||||
|`allow_blame` |not set if `false`|
|
||||
link:config-gerrit.html#change.allowBlame[Whether blame on side by side diff is
|
||||
allowed].
|
||||
|`large_change` ||
|
||||
link:config-gerrit.html#change.largeChange[Number of changed lines from
|
||||
which on a change is considered as a large change].
|
||||
|`reply_label` ||
|
||||
link:config-gerrit.html#change.replyTooltip[Label name for the reply
|
||||
button].
|
||||
|
@@ -19,7 +19,6 @@ public class ChangeConfigInfo {
|
||||
public Boolean allowBlame;
|
||||
public Boolean showAssigneeInChangesTable;
|
||||
public Boolean disablePrivateChanges;
|
||||
public int largeChange;
|
||||
public String replyLabel;
|
||||
public String replyTooltip;
|
||||
public int updateDelay;
|
||||
|
@@ -222,7 +222,6 @@ public class GetServerInfo implements RestReadView<ConfigResource> {
|
||||
info.showAssigneeInChangesTable =
|
||||
toBoolean(
|
||||
config.getBoolean("change", "showAssigneeInChangesTable", false) && hasAssigneeInIndex);
|
||||
info.largeChange = config.getInt("change", "largeChange", 500);
|
||||
info.replyTooltip =
|
||||
Optional.ofNullable(config.getString("change", null, "replyTooltip"))
|
||||
.orElse("Reply and score")
|
||||
|
@@ -58,7 +58,6 @@ public class ServerInfoIT extends AbstractDaemonTest {
|
||||
@GerritConfig(name = "auth.httpPasswordUrl", value = "https://example.com/password")
|
||||
|
||||
// change
|
||||
@GerritConfig(name = "change.largeChange", value = "300")
|
||||
@GerritConfig(name = "change.replyTooltip", value = "Publish votes and draft comments")
|
||||
@GerritConfig(name = "change.replyLabel", value = "Vote")
|
||||
@GerritConfig(name = "change.updateDelay", value = "50s")
|
||||
@@ -102,7 +101,6 @@ public class ServerInfoIT extends AbstractDaemonTest {
|
||||
assertThat(i.auth.httpPasswordUrl).isNull();
|
||||
|
||||
// change
|
||||
assertThat(i.change.largeChange).isEqualTo(300);
|
||||
assertThat(i.change.replyTooltip).startsWith("Publish votes and draft comments");
|
||||
assertThat(i.change.replyLabel).isEqualTo("Vote\u2026");
|
||||
assertThat(i.change.updateDelay).isEqualTo(50);
|
||||
@@ -170,7 +168,6 @@ public class ServerInfoIT extends AbstractDaemonTest {
|
||||
assertThat(i.auth.httpPasswordUrl).isNull();
|
||||
|
||||
// change
|
||||
assertThat(i.change.largeChange).isEqualTo(500);
|
||||
assertThat(i.change.replyTooltip).startsWith("Reply and score");
|
||||
assertThat(i.change.replyLabel).isEqualTo("Reply\u2026");
|
||||
assertThat(i.change.updateDelay).isEqualTo(300);
|
||||
|
Reference in New Issue
Block a user