opendev/gerrit
Code Issues Proposed changes

Move project and settings tabs to left side

Browse Source 
Instead of using a GWT TabPanel to show the project and settings tabs,
move them onto the left as part of a vertically stacked menu.  This
just looks cleaner, and helps us to avoid ultra wide windows in the
settings area as the number of tabs keeps increasing.

While we are doing the UI refactoring, make each section proper top
level screen objects.  This makes it far easier to ensure the data is
loaded in the background before the UI gets displayed, which removes
some of the display jitter you see as you navigate to a section.

This also nicely fixes some table UI layout glitches that were caused
by the TabPanel forcing our content width to 100% even though we
didn't want that.

Change-Id: I5da0dadddc2746206852a0873d6014051bd9f6dc
Signed-off-by: Shawn O. Pearce <sop@google.com>
This commit is contained in:
Shawn O. Pearce
2010-07-14 20:22:22 -07:00
parent 14bedca306
commit 270c5941d4
28 changed files with 534 additions and 479 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/account/ValidateEmailScreen.java
View File

@@ -30,7 +30,7 @@ public class ValidateEmailScreen extends AccountScreen {
@Override
protected void onInitUI() {
super.onInitUI();
setPageTitle(Util.C.accountSettingsHeading());
setPageTitle(Util.C.settingsHeading());
}
@Override