opendev/gerrit
Code Issues Proposed changes

CommitInfo: Use ToStringHelper

Browse Source 
This extension class is not used by the UI and so can have a Guava
dependency. Upon further consideration, using the raw JGit commit format
wouldn't provide any benefit here, as the string is just for debugging.

Change-Id: Iaef50fb95b7d747aaddbbabf034ad41296490f80
This commit is contained in:
Dave Borowitz
2018-10-16 11:06:56 -07:00
parent 74df92474d
commit 274124bee7
1 changed files with 11 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
java/com/google/gerrit/extensions/common/CommitInfo.java
View File

@@ -16,6 +16,8 @@ package com.google.gerrit.extensions.common;
import static java.util.stream.Collectors.joining; import static java.util.stream.Collectors.joining;
import com.google.common.base.MoreObjects;
import com.google.common.base.MoreObjects.ToStringHelper;
import java.util.List; import java.util.List;
import java.util.Objects; import java.util.Objects;
@@ -50,19 +52,18 @@ public class CommitInfo {
@Override @Override
public String toString() { public String toString() {
// Using something like the raw commit format might be nice, but we can't depend on JGit here. ToStringHelper helper = MoreObjects.toStringHelper(this).addValue(commit);
StringBuilder sb = new StringBuilder().append(getClass().getSimpleName()).append('{');
sb.append(commit);
if (parents != null) { if (parents != null) {
sb.append(", parents=").append(parents.stream().map(p -> p.commit).collect(joining(", "))); helper.add("parents", parents.stream().map(p -> p.commit).collect(joining(", ")));
} }
sb.append(", author=").append(author); helper
sb.append(", committer=").append(committer); .add("author", author)
sb.append(", subject=").append(subject); .add("committer", committer)
sb.append(", message=").append(message); .add("subject", subject)
.add("message", message);
if (webLinks != null) { if (webLinks != null) {
sb.append(", webLinks=").append(webLinks); helper.add("webLinks", webLinks);
} }
return sb.append('}').toString(); return helper.toString();
} }
} }