opendev/gerrit
Code Issues Proposed changes

Use ProjectUtil.stripGitSuffix in CreateProjectScreen

Browse Source 
The ProjectUtil class no longer imports JGit constants, so it
is now possible to use it in UI code.

Change-Id: I977747211c69eb18694b27a12088e8c3fddc2d2b
This commit is contained in:
David Pursehouse
2013-02-20 09:49:40 +09:00
parent 3639121f1e
commit 275639602a
1 changed files with 2 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/CreateProjectScreen.java
View File

@@ -30,6 +30,7 @@ import com.google.gerrit.client.ui.ProjectNameSuggestOracle;
import com.google.gerrit.client.ui.ProjectsTable;
import com.google.gerrit.client.ui.Screen;
import com.google.gerrit.common.PageLinks;
import com.google.gerrit.common.ProjectUtil;
import com.google.gerrit.reviewdb.client.Project;
import com.google.gwt.event.dom.client.ClickEvent;
import com.google.gwt.event.dom.client.ClickHandler;
@@ -235,20 +236,7 @@ public class CreateProjectScreen extends Screen {
new GerritCallback<VoidResult>() {
@Override
public void onSuccess(VoidResult result) {
String nameWithoutSuffix = projectName;
if (nameWithoutSuffix.endsWith(".git")) {
// Be nice and drop the trailing ".git" suffix, which we never
// keep in our database, but clients might mistakenly provide
// anyway.
//
nameWithoutSuffix = nameWithoutSuffix.substring(0, //
nameWithoutSuffix.length() - 4);
while (nameWithoutSuffix.endsWith("/")) {
nameWithoutSuffix = nameWithoutSuffix.substring(//
0, nameWithoutSuffix.length() - 1);
}
}
String nameWithoutSuffix = ProjectUtil.stripGitSuffix(projectName);
History.newItem(Dispatcher.toProjectAdmin(new Project.NameKey(
nameWithoutSuffix), ProjectScreen.INFO));
}