From 2761a28d3dd2f983fd438c8dd3145987f62213af Mon Sep 17 00:00:00 2001 From: "Shawn O. Pearce" Date: Fri, 13 Feb 2009 18:57:07 -0800 Subject: [PATCH] Actually return failure to clients if new change creation failed If a new change creation failed we were overwriting the result with OK, which was wrong. The client should know we rejected the push as something failed our end. Signed-off-by: Shawn O. Pearce --- src/main/java/com/google/gerrit/server/ssh/Receive.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/main/java/com/google/gerrit/server/ssh/Receive.java b/src/main/java/com/google/gerrit/server/ssh/Receive.java index c27ff57bcf..c7cd01702d 100644 --- a/src/main/java/com/google/gerrit/server/ssh/Receive.java +++ b/src/main/java/com/google/gerrit/server/ssh/Receive.java @@ -585,9 +585,11 @@ class Receive extends AbstractGitCommand { } catch (IOException e) { log.error("Error computing patch of commit " + c.name(), e); reject(newChange, "diff error"); + return; } catch (OrmException e) { log.error("Error creating change for commit " + c.name(), e); reject(newChange, "database error"); + return; } } newChange.setResult(ReceiveCommand.Result.OK);