opendev/gerrit
Code Issues Proposed changes

Make gitweb url links customizable, add support for cgit

Browse Source 
The gitweb.type variable can now be one of the following: "gitweb",
"cgit" or "custom", with suitable defaults for other variables
selected based on the preferred URL format for that gitweb type.

If gitweb.type = custom is used, then URL patterns must be defined
in the gerrit.config file:

  [gitweb]
    project = ${project}/summary
    revision = ${project}/commit/${commit}
    branch = ${project}/log/?h=${branch}

In a custom configuration, all 3 variables must be defined or gitweb
integration will be disabled.

Bug: issue 366
Bug: issue 371
Change-Id: Ic681af1300b9c7cbae1f0f0ce31a5272378feac6
Signed-off-by: Shawn O. Pearce <sop@google.com>
This commit is contained in:
Shane Mc Cormack
2009-12-28 04:49:39 +00:00
committed by Shawn O. Pearce
parent 5f95a93f0f
commit 27868a42d9
11 changed files with 220 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

172
gerrit-common/src/test/java/com/google/gerrit/common/data/ParamertizedStringTest.java Normal file
View File

@@ -0,0 +1,172 @@
// Copyright (C) 2009 The Android Open Source Project
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package com.google.gerrit.common.data;
import junit.framework.TestCase;
import java.util.HashMap;
import java.util.Map;
public class ParamertizedStringTest extends TestCase {
public void testEmptyString() {
final ParamertizedString p = new ParamertizedString("");
assertEquals("", p.getPattern());
assertEquals("", p.getRawPattern());
assertTrue(p.getParameterNames().isEmpty());
final Map<String, String> a = new HashMap<String, String>();
assertNotNull(p.bind(a));
assertEquals(0, p.bind(a).length);
assertEquals("", p.replace(a));
}
public void testAsis1() {
final ParamertizedString p = ParamertizedString.asis("${bar}c");
assertEquals("${bar}c", p.getPattern());
assertEquals("${bar}c", p.getRawPattern());
assertTrue(p.getParameterNames().isEmpty());
final Map<String, String> a = new HashMap<String, String>();
a.put("bar", "frobinator");
assertNotNull(p.bind(a));
assertEquals(0, p.bind(a).length);
assertEquals("${bar}c", p.replace(a));
}
public void testReplace1() {
final ParamertizedString p = new ParamertizedString("${bar}c");
assertEquals("${bar}c", p.getPattern());
assertEquals("{0}c", p.getRawPattern());
assertEquals(1, p.getParameterNames().size());
assertTrue(p.getParameterNames().contains("bar"));
final Map<String, String> a = new HashMap<String, String>();
a.put("bar", "frobinator");
assertNotNull(p.bind(a));
assertEquals(1, p.bind(a).length);
assertEquals("frobinator", p.bind(a)[0]);
assertEquals("frobinatorc", p.replace(a));
}
public void testReplace2() {
final ParamertizedString p = new ParamertizedString("a${bar}c");
assertEquals("a${bar}c", p.getPattern());
assertEquals("a{0}c", p.getRawPattern());
assertEquals(1, p.getParameterNames().size());
assertTrue(p.getParameterNames().contains("bar"));
final Map<String, String> a = new HashMap<String, String>();
a.put("bar", "frobinator");
assertNotNull(p.bind(a));
assertEquals(1, p.bind(a).length);
assertEquals("frobinator", p.bind(a)[0]);
assertEquals("afrobinatorc", p.replace(a));
}
public void testReplace3() {
final ParamertizedString p = new ParamertizedString("a${bar}");
assertEquals("a${bar}", p.getPattern());
assertEquals("a{0}", p.getRawPattern());
assertEquals(1, p.getParameterNames().size());
assertTrue(p.getParameterNames().contains("bar"));
final Map<String, String> a = new HashMap<String, String>();
a.put("bar", "frobinator");
assertNotNull(p.bind(a));
assertEquals(1, p.bind(a).length);
assertEquals("frobinator", p.bind(a)[0]);
assertEquals("afrobinator", p.replace(a));
}
public void testReplace4() {
final ParamertizedString p = new ParamertizedString("a${bar}c");
assertEquals("a${bar}c", p.getPattern());
assertEquals("a{0}c", p.getRawPattern());
assertEquals(1, p.getParameterNames().size());
assertTrue(p.getParameterNames().contains("bar"));
final Map<String, String> a = new HashMap<String, String>();
assertNotNull(p.bind(a));
assertEquals(1, p.bind(a).length);
assertEquals("", p.bind(a)[0]);
assertEquals("ac", p.replace(a));
}
public void testReplaceToLowerCase() {
final ParamertizedString p = new ParamertizedString("${a.toLowerCase}");
assertEquals(1, p.getParameterNames().size());
assertTrue(p.getParameterNames().contains("a"));
final Map<String, String> a = new HashMap<String, String>();
a.put("a", "foo");
assertNotNull(p.bind(a));
assertEquals(1, p.bind(a).length);
assertEquals("foo", p.bind(a)[0]);
assertEquals("foo", p.replace(a));
a.put("a", "FOO");
assertNotNull(p.bind(a));
assertEquals(1, p.bind(a).length);
assertEquals("foo", p.bind(a)[0]);
assertEquals("foo", p.replace(a));
}
public void testReplaceToUpperCase() {
final ParamertizedString p = new ParamertizedString("${a.toUpperCase}");
assertEquals(1, p.getParameterNames().size());
assertTrue(p.getParameterNames().contains("a"));
final Map<String, String> a = new HashMap<String, String>();
a.put("a", "foo");
assertNotNull(p.bind(a));
assertEquals(1, p.bind(a).length);
assertEquals("FOO", p.bind(a)[0]);
assertEquals("FOO", p.replace(a));
a.put("a", "FOO");
assertNotNull(p.bind(a));
assertEquals(1, p.bind(a).length);
assertEquals("FOO", p.bind(a)[0]);
assertEquals("FOO", p.replace(a));
}
public void testReplaceLocalName() {
final ParamertizedString p = new ParamertizedString("${a.localPart}");
assertEquals(1, p.getParameterNames().size());
assertTrue(p.getParameterNames().contains("a"));
final Map<String, String> a = new HashMap<String, String>();
a.put("a", "foo@example.com");
assertNotNull(p.bind(a));
assertEquals(1, p.bind(a).length);
assertEquals("foo", p.bind(a)[0]);
assertEquals("foo", p.replace(a));
a.put("a", "foo");
assertNotNull(p.bind(a));
assertEquals(1, p.bind(a).length);
assertEquals("foo", p.bind(a)[0]);
assertEquals("foo", p.replace(a));
}
public void testUndefinedFunctionName() {
ParamertizedString p = new ParamertizedString("${a.anUndefinedMethod}");
assertEquals(1, p.getParameterNames().size());
assertTrue(p.getParameterNames().contains("a.anUndefinedMethod"));
}
}