opendev/gerrit
Code Issues Proposed changes

Cleanup text field in CherryPickDialog

Browse Source 
The branch text field in CherryPickDialog didn't match the message
field immediately below it.  It wasn't the same width, wasn't tabbed
in, and didn't have the same border decoration.  Making them match
is much more visually appealing.

Change-Id: I97fb99428cd5d4f05435d9ba4017d1e6cfc9bb93
This commit is contained in:
Brad Larson
2013-08-09 15:35:08 -05:00
parent 6dbd2e6cc4
commit 286b201d54
1 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/CherryPickDialog.java
View File

@@ -14,6 +14,7 @@
package com.google.gerrit.client.ui;
import com.google.gerrit.client.Gerrit;
import com.google.gerrit.client.changes.Util;
import com.google.gerrit.client.projects.BranchInfo;
import com.google.gerrit.client.projects.ProjectApi;
@@ -21,6 +22,8 @@ import com.google.gerrit.client.rpc.GerritCallback;
import com.google.gerrit.client.rpc.Natives;
import com.google.gerrit.reviewdb.client.Project;
import com.google.gwt.core.client.JsArray;
import com.google.gwt.user.client.DOM;
import com.google.gwt.user.client.ui.FlowPanel;
import com.google.gwt.user.client.ui.FocusWidget;
import com.google.gwt.user.client.ui.SuggestBox;
import com.google.gwt.user.client.ui.SuggestOracle.Suggestion;
@@ -59,9 +62,15 @@ public abstract class CherryPickDialog extends ActionDialog {
}
});
newBranch.setWidth("70ex");
newBranch.setWidth("100%");
DOM.setStyleAttribute(newBranch.getElement(), "box-sizing", "border-box");
message.setCharacterWidth(70);
panel.insert(newBranch, 0);
final FlowPanel mwrap = new FlowPanel();
mwrap.setStyleName(Gerrit.RESOURCES.css().commentedActionMessage());
mwrap.add(newBranch);
panel.insert(mwrap, 0);
panel.insert(new SmallHeading(Util.C.headingCherryPickBranch()), 0);
}