opendev/gerrit
Code Issues Proposed changes

Allow ChangeControl.Factory#create(RefControl, Change) to throw OrmException

Browse Source 
This method will need to throw OrmException when the
ChangeNotes.Factory will be responsible for loading changes from the
database, which may fail with an OrmException.

Change-Id: I25c69e634eca63a89761032e87ecc78faff525b0
Signed-off-by: Edwin Kempin <ekempin@google.com>
This commit is contained in:
Edwin Kempin
2016-02-03 12:43:53 +01:00
parent 668fa7cda9
commit 28b7a0f0ca
8 changed files with 20 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-server/src/main/java/com/google/gerrit/server/change/Revisions.java
View File

@@ -138,7 +138,7 @@ public class Revisions implements ChildCollection<ChangeResource, RevisionResour
}
private List<RevisionResource> loadEdit(ChangeResource change, RevId revid)
throws AuthException, IOException {
throws AuthException, IOException, OrmException {
Optional<ChangeEdit> edit = editUtil.byChange(change.getChange());
if (edit.isPresent()) {
PatchSet ps = new PatchSet(new PatchSet.Id(change.getId(), 0));