opendev/gerrit
Code Issues Proposed changes

Don’t limit query results to open changes when no index predicate is used

Browse Source 
If a change query doesn’t contain any index predicate, but only post
filter predicates the query result was limited to open changes only.
E.g. “reviewerin:Users” was finding only open changes while
“reviewerin:Users message:foo” considered open and closed changes. This
behaviour was confusing users.

Bug: Issue 8597
Change-Id: I88d93d60a5572345a4c4e8a5d58628b4c1a4851d
Signed-off-by: Edwin Kempin <ekempin@google.com>
This commit is contained in:
Edwin Kempin
2018-04-18 10:00:27 +02:00
parent 393e008070
commit 28c50a4ee5
4 changed files with 10 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
Documentation/user-search.txt
View File

@@ -108,9 +108,7 @@ Changes originally submitted by 'USER'. The special case of
[[ownerin]]
ownerin:'GROUP'::
+
Changes originally submitted by a user in 'GROUP'. When no other index
predicate is explicitly added in the query, defaults to only include
changes in status 'OPEN'.
Changes originally submitted by a user in 'GROUP'.
[[query]]
query:'NAME'::
@@ -139,9 +137,7 @@ Changes that revert the change specified by the numeric 'ID'.
[[reviewerin]]
reviewerin:'GROUP'::
+
Changes that have been, or need to be, reviewed by a user in 'GROUP'. When
no other index predicate is explicitly added in the query, defaults to only
include changes in status 'OPEN'.
Changes that have been, or need to be, reviewed by a user in 'GROUP'.
[[commit]]
commit:'SHA1'::