opendev/gerrit
Code Issues Proposed changes

Fix nits in ProjectConfig and AccessSection

Browse Source 
Change-Id: If58fe095c5e02e80d466c6fe17ff2dbfe0f1b7ac
This commit is contained in:
Patrick Hiesel
2020-07-10 12:30:45 +02:00
parent 225fd6120b
commit 28d7329129
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
java/com/google/gerrit/common/data/AccessSection.java
View File

@@ -98,7 +98,7 @@ public abstract class AccessSection implements Comparable<AccessSection> {
public abstract static class Builder { public abstract static class Builder {
private final List<Permission.Builder> permissionBuilders; private final List<Permission.Builder> permissionBuilders;
public Builder() { protected Builder() {
permissionBuilders = new ArrayList<>(); permissionBuilders = new ArrayList<>();
} }

2
java/com/google/gerrit/server/project/ProjectConfig.java
View File

@@ -408,7 +408,7 @@ public class ProjectConfig extends VersionedMetaData implements ValidationError.
String name = section.getName(); String name = section.getName();
if (sectionsWithUnknownPermissions.contains(name)) { if (sectionsWithUnknownPermissions.contains(name)) {
AccessSection.Builder a = accessSections.get(name).toBuilder(); AccessSection.Builder a = accessSections.get(name).toBuilder();
a.modifyPermissions(p -> p.clear()); a.modifyPermissions(List::clear);
accessSections.put(name, a.build()); accessSections.put(name, a.build());
} else { } else {
accessSections.remove(name); accessSections.remove(name);