opendev/gerrit
Code Issues Proposed changes

Remove default bug tracker from _feedbackUrl

Browse Source 
Bug: Issue 11216
Change-Id: I5cd33d8f74118a0e9b3c96a3bce949092181cc45
This commit is contained in:
Paladox none
2019-07-25 21:57:04 +00:00
parent 2a5dfa8029
commit 28f2e51144
2 changed files with 12 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
polygerrit-ui/app/elements/gr-app-element.html
View File

@@ -196,7 +196,9 @@ limitations under the License.
<div> <div>
<a class="feedback" <a class="feedback"
href$="[[_feedbackUrl]]" href$="[[_feedbackUrl]]"
rel="noopener" target="_blank">Report bug</a> rel="noopener"
target="_blank"
hidden$="[[!_showFeedbackUrl(_feedbackUrl)]]">Report bug</a>
| Press &ldquo;?&rdquo; for keyboard shortcuts | Press &ldquo;?&rdquo; for keyboard shortcuts
<gr-endpoint-decorator name="footer-right"></gr-endpoint-decorator> <gr-endpoint-decorator name="footer-right"></gr-endpoint-decorator>
</div> </div>

14
polygerrit-ui/app/elements/gr-app-element.js
View File

@@ -78,11 +78,7 @@
computed: '_computePluginScreenName(params)', computed: '_computePluginScreenName(params)',
}, },
_settingsUrl: String, _settingsUrl: String,
_feedbackUrl: { _feedbackUrl: String,
type: String,
value: 'https://bugs.chromium.org/p/gerrit/issues/entry' +
'?template=PolyGerrit%20Issue',
},
// Used to allow searching on mobile // Used to allow searching on mobile
mobileSearch: { mobileSearch: {
type: Boolean, type: Boolean,
@@ -441,5 +437,13 @@
_mobileSearchToggle(e) { _mobileSearchToggle(e) {
this.mobileSearch = !this.mobileSearch; this.mobileSearch = !this.mobileSearch;
}, },
_showFeedbackUrl(feedbackUrl) {
if (feedbackUrl) {
return feedbackUrl;
}
return false;
},
}); });
})(); })();