Format all Java files with google-java-format
Having a standard tool for formatting saves reviewers' valuable time. google-java-format is Google's standard formatter and is somewhat inspired by gofmt[1]. This commit formats everything using google-java-format version 1.2. The downside of this one-off formatting is breaking blame. This can be somewhat hacked around with a tool like git-hyper-blame[2], but it's definitely not optimal until/unless this kind of feature makes its way to git core. Not in this change: * Tool support, e.g. Eclipse. The command must be run manually [3]. * Documentation of best practice, e.g. new 100-column default. [1] https://talks.golang.org/2015/gofmt-en.slide#3 [2] https://commondatastorage.googleapis.com/chrome-infra-docs/flat/depot_tools/docs/html/git-hyper-blame.html [3] git ls-files | grep java$ | xargs google-java-format -i Change-Id: Id5f3c6de95ce0b68b41f0a478b5c99a93675aaa3 Signed-off-by: David Pursehouse <dpursehouse@collab.net>
This commit is contained in:
committed by
David Pursehouse
parent
6723b6d0fa
commit
292fa154c1
@@ -14,7 +14,6 @@
|
||||
|
||||
package com.google.gerrit.extensions.client;
|
||||
|
||||
|
||||
import static com.google.gerrit.extensions.client.RangeSubject.assertThat;
|
||||
|
||||
import org.junit.Test;
|
||||
@@ -75,8 +74,8 @@ public class RangeTest {
|
||||
assertThat(range).isInvalid();
|
||||
}
|
||||
|
||||
private Comment.Range createRange(int startLine, int startCharacter,
|
||||
int endLine, int endCharacter) {
|
||||
private Comment.Range createRange(
|
||||
int startLine, int startCharacter, int endLine, int endCharacter) {
|
||||
Comment.Range range = new Comment.Range();
|
||||
range.startLine = startLine;
|
||||
range.startCharacter = startCharacter;
|
||||
|
||||
Reference in New Issue
Block a user