Format all Java files with google-java-format

Having a standard tool for formatting saves reviewers' valuable time.
google-java-format is Google's standard formatter and is somewhat
inspired by gofmt[1]. This commit formats everything using
google-java-format version 1.2.

The downside of this one-off formatting is breaking blame. This can be
somewhat hacked around with a tool like git-hyper-blame[2], but it's
definitely not optimal until/unless this kind of feature makes its way
to git core.

Not in this change:
* Tool support, e.g. Eclipse. The command must be run manually [3].
* Documentation of best practice, e.g. new 100-column default.

[1] https://talks.golang.org/2015/gofmt-en.slide#3
[2] https://commondatastorage.googleapis.com/chrome-infra-docs/flat/depot_tools/docs/html/git-hyper-blame.html
[3] git ls-files | grep java$ | xargs google-java-format -i

Change-Id: Id5f3c6de95ce0b68b41f0a478b5c99a93675aaa3
Signed-off-by: David Pursehouse <dpursehouse@collab.net>
This commit is contained in:
Dave Borowitz
2016-11-13 09:56:32 -08:00
committed by David Pursehouse
parent 6723b6d0fa
commit 292fa154c1
2443 changed files with 54816 additions and 57825 deletions

View File

@@ -15,149 +15,252 @@
package com.google.gerrit.client.admin;
import com.google.gwt.i18n.client.Constants;
import java.util.Map;
public interface AdminConstants extends Constants {
String defaultAccountName();
String defaultAccountGroupName();
String defaultBranchName();
String defaultRevisionSpec();
String buttonDeleteIncludedGroup();
String buttonAddIncludedGroup();
String buttonDeleteGroupMembers();
String buttonAddGroupMember();
String buttonSaveDescription();
String buttonRenameGroup();
String buttonCreateGroup();
String buttonCreateProject();
String buttonChangeGroupOwner();
String buttonChangeGroupType();
String buttonSelectGroup();
String buttonSaveChanges();
String checkBoxEmptyCommit();
String checkBoxPermissionsOnly();
String useContentMerge();
String useContributorAgreements();
String useSignedOffBy();
String createNewChangeForAllNotInTarget();
String enableSignedPush();
String requireSignedPush();
String requireChangeID();
String rejectImplicitMerges();
String headingMaxObjectSizeLimit();
String headingGroupOptions();
String isVisibleToAll();
String buttonSaveGroupOptions();
String suggestedGroupLabel();
String parentSuggestions();
String buttonBrowseProjects();
String projects();
String projectRepoBrowser();
String headingGroupUUID();
String headingOwner();
String headingDescription();
String headingProjectOptions();
String headingProjectCommands();
String headingCommands();
String headingMembers();
String headingIncludedGroups();
String noMembersInfo();
String headingExternalGroup();
String headingCreateGroup();
String headingParentProjectName();
String columnProjectName();
String headingAgreements();
String headingAuditLog();
String headingProjectSubmitType();
String projectSubmitType_FAST_FORWARD_ONLY();
String projectSubmitType_MERGE_ALWAYS();
String projectSubmitType_MERGE_IF_NECESSARY();
String projectSubmitType_REBASE_IF_NECESSARY();
String projectSubmitType_REBASE_ALWAYS();
String projectSubmitType_CHERRY_PICK();
String headingProjectState();
String projectState_ACTIVE();
String projectState_READ_ONLY();
String projectState_HIDDEN();
String columnMember();
String columnEmailAddress();
String columnGroupName();
String columnGroupDescription();
String columnGroupType();
String columnGroupNotifications();
String columnGroupVisibleToAll();
String columnDate();
String columnType();
String columnByUser();
String typeAdded();
String typeRemoved();
String columnBranchName();
String columnBranchRevision();
String initialRevision();
String buttonAddBranch();
String buttonDeleteBranch();
String saveHeadButton();
String cancelHeadButton();
String columnTagName();
String groupItemHelp();
String groupListTitle();
String groupFilter();
String createGroupTitle();
String groupTabGeneral();
String groupTabMembers();
String groupTabAuditLog();
String projectListTitle();
String projectFilter();
String createProjectTitle();
String projectListQueryLink();
String plugins();
String pluginEnabled();
String pluginDisabled();
String pluginSettingsToolTip();
String columnPluginName();
String columnPluginSettings();
String columnPluginVersion();
String columnPluginStatus();
String noGroupSelected();
String errorNoMatchingGroups();
String errorNoGitRepository();
String addPermission();
Map<String,String> permissionNames();
Map<String, String> permissionNames();
String refErrorEmpty();
String refErrorBeginSlash();
String refErrorDoubleSlash();
String refErrorNoSpace();
String refErrorPrintable();
String errorsMustBeFixed();
String sectionTypeReference();
String sectionTypeSection();
Map<String, String> sectionNames();
String pagedListPrev();
String pagedListNext();
String buttonCreate();
String buttonCreateDescription();
String buttonCreateChange();
String buttonCreateChangeDescription();
String buttonEditConfig();
String buttonEditConfigDescription();
String editConfigMessage();
}