Format all Java files with google-java-format

Having a standard tool for formatting saves reviewers' valuable time.
google-java-format is Google's standard formatter and is somewhat
inspired by gofmt[1]. This commit formats everything using
google-java-format version 1.2.

The downside of this one-off formatting is breaking blame. This can be
somewhat hacked around with a tool like git-hyper-blame[2], but it's
definitely not optimal until/unless this kind of feature makes its way
to git core.

Not in this change:
* Tool support, e.g. Eclipse. The command must be run manually [3].
* Documentation of best practice, e.g. new 100-column default.

[1] https://talks.golang.org/2015/gofmt-en.slide#3
[2] https://commondatastorage.googleapis.com/chrome-infra-docs/flat/depot_tools/docs/html/git-hyper-blame.html
[3] git ls-files | grep java$ | xargs google-java-format -i

Change-Id: Id5f3c6de95ce0b68b41f0a478b5c99a93675aaa3
Signed-off-by: David Pursehouse <dpursehouse@collab.net>
This commit is contained in:
Dave Borowitz
2016-11-13 09:56:32 -08:00
committed by David Pursehouse
parent 6723b6d0fa
commit 292fa154c1
2443 changed files with 54816 additions and 57825 deletions

View File

@@ -24,14 +24,8 @@ import com.google.gwt.core.client.JavaScriptObject;
public class RevisionGlue {
public static void onAction(
ChangeInfo change,
RevisionInfo revision,
ActionInfo action,
ActionButton button) {
RestApi api = ChangeApi.revision(
change.legacyId().get(),
revision.name())
.view(action.id());
ChangeInfo change, RevisionInfo revision, ActionInfo action, ActionButton button) {
RestApi api = ChangeApi.revision(change.legacyId().get(), revision.name()).view(action.id());
JavaScriptObject f = get(action.id());
if (f != null) {
@@ -50,6 +44,5 @@ public class RevisionGlue {
return $wnd.Gerrit.revision_actions[id];
}-*/;
private RevisionGlue() {
}
private RevisionGlue() {}
}