opendev/gerrit
Code Issues Proposed changes

Format all Java files with google-java-format

Browse Source 
Having a standard tool for formatting saves reviewers' valuable time.
google-java-format is Google's standard formatter and is somewhat
inspired by gofmt[1]. This commit formats everything using
google-java-format version 1.2.

The downside of this one-off formatting is breaking blame. This can be
somewhat hacked around with a tool like git-hyper-blame[2], but it's
definitely not optimal until/unless this kind of feature makes its way
to git core.

Not in this change:
* Tool support, e.g. Eclipse. The command must be run manually [3].
* Documentation of best practice, e.g. new 100-column default.

[1] https://talks.golang.org/2015/gofmt-en.slide#3
[2] https://commondatastorage.googleapis.com/chrome-infra-docs/flat/depot_tools/docs/html/git-hyper-blame.html
[3] git ls-files | grep java$ | xargs google-java-format -i

Change-Id: Id5f3c6de95ce0b68b41f0a478b5c99a93675aaa3
Signed-off-by: David Pursehouse <dpursehouse@collab.net>
This commit is contained in:
Dave Borowitz
2016-11-13 09:56:32 -08:00
committed by David Pursehouse
parent 6723b6d0fa
commit 292fa154c1
2443 changed files with 54816 additions and 57825 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
gerrit-server/src/main/java/com/google/gerrit/server/change/ReviewerResource.java
View File

@@ -30,6 +30,7 @@ public class ReviewerResource implements RestResource {
public interface Factory {
ReviewerResource create(ChangeResource change, Account.Id id);
ReviewerResource create(RevisionResource revision, Account.Id id);
}
@@ -38,7 +39,8 @@ public class ReviewerResource implements RestResource {
private final IdentifiedUser user;
@AssistedInject
ReviewerResource(IdentifiedUser.GenericFactory userFactory,
ReviewerResource(
IdentifiedUser.GenericFactory userFactory,
@Assisted ChangeResource change,
@Assisted Account.Id id) {
this.change = change;
@@ -47,7 +49,8 @@ public class ReviewerResource implements RestResource {
}
@AssistedInject
ReviewerResource(IdentifiedUser.GenericFactory userFactory,
ReviewerResource(
IdentifiedUser.GenericFactory userFactory,
@Assisted RevisionResource revision,
@Assisted Account.Id id) {
this.revision = revision;
@@ -76,16 +79,16 @@ public class ReviewerResource implements RestResource {
}
/**
* @return the control for the caller's user (as opposed to the reviewer's
* user as returned by {@link #getReviewerControl()}).
* @return the control for the caller's user (as opposed to the reviewer's user as returned by
* {@link #getReviewerControl()}).
*/
public ChangeControl getControl() {
return change.getControl();
}
/**
* @return the control for the reviewer's user (as opposed to the caller's
* user as returned by {@link #getControl()}).
* @return the control for the reviewer's user (as opposed to the caller's user as returned by
* {@link #getControl()}).
*/
public ChangeControl getReviewerControl() {
return change.getControl().forUser(user);