opendev/gerrit
Code Issues Proposed changes

Merge "ChangeScreen2: Highlight the opened right side popdown panel"

Browse Source
This commit is contained in:
Edwin Kempin 2013-08-27 05:29:30 +00:00 committed by Gerrit Code Review
commit 29562f109f
3 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ChangeScreen2.java
View File

@ -102,6 +102,7 @@ public class ChangeScreen2 extends Screen {
String label_may();
String label_need();
String replyBox();
String selected();
}
private final Change.Id changeId;

11
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ChangeScreen2.ui.xml
View File

@ -92,11 +92,11 @@ limitations under the License.
cursor: pointer;
height: 25px;
border: none;
border-left: 1px solid #fff;
border-left: 2px solid #fff;
background-color: trimColor;
margin-right: 0;
padding-left: 0;
padding-right: 0;
margin: 0;
padding-left: 2px;
padding-right: 2px;
}
.popdown button div {
padding-left: 6px;
@ -105,6 +105,9 @@ limitations under the License.
.popdown button div:after {
content: " \25bc";
}
.popdown button.selected {
font-weight: bold;
}
.headerTable {
border-spacing: 0;

3
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RightSidePopdownAction.java
View File

@ -44,6 +44,7 @@ abstract class RightSidePopdownAction {
void show() {
if (popup != null) {
button.removeStyleName(style.selected());
popup.hide();
return;
}
@ -68,6 +69,7 @@ abstract class RightSidePopdownAction {
@Override
public void onClose(CloseEvent<PopupPanel> event) {
if (popup == p) {
button.removeStyleName(style.selected());
popup = null;
}
}
@ -75,6 +77,7 @@ abstract class RightSidePopdownAction {
p.add(getWidget());
p.showRelativeTo(relativeTo);
GlobalKey.dialog(p);
button.addStyleName(style.selected());
popup = p;
}
}