opendev/gerrit
Code Issues Proposed changes

Permit cache.diff.intraline to disable MyersDiff

Browse Source 
I can't fix the infinite loop in JGit's MyersDiff implementation in
a reasonable time frame.  But its a data dependent bug that triggers
only rarely, most of the time the intraline difference feature works
"well enough" to be useful, and a number of sites are running with
it live.

Lets make it available by default, but give the server administrator
a way to easily opt-out of the feature if they run into the same
sort of bug that issue 487 identifies.

Bug: issue 487
Change-Id: I257be95ac93c0775d24fcd36a315f293503febb7
Signed-off-by: Shawn O. Pearce <sop@google.com>
This commit is contained in:
Shawn O. Pearce
2010-03-03 17:51:26 -08:00
parent afd1514e5e
commit 29de43630a
10 changed files with 69 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchListKey.java
View File

@@ -35,7 +35,7 @@ import java.io.Serializable;
import javax.annotation.Nullable;
public class PatchListKey implements Serializable {
static final long serialVersionUID = 12L;
static final long serialVersionUID = 13L;
private transient ObjectId oldId;
private transient ObjectId newId;