opendev/gerrit
Code Issues Proposed changes

Small stylistic fixes to ReviewersUtil and AccountState

Browse Source 
+ GroupAsReviewer is an inner class but doesn’t refer to the
  outer class. It can be marked static.
+ ACCOUNT_ID_FUNCTION is constant case and never changed, so
  mark it as final.

Change-Id: Ieb9346c577adaa3d8460649cb4525ad06d44ad7d
This commit is contained in:
Andrew Bonventre
2016-07-21 17:02:00 -04:00
parent 677439d7ce
commit 2a15535d76
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-server/src/main/java/com/google/gerrit/server/ReviewersUtil.java
View File

@@ -276,7 +276,7 @@ public class ReviewersUtil {
suggestReviewers.getLimit())); suggestReviewers.getLimit()));
} }
private class GroupAsReviewer { private static class GroupAsReviewer {
boolean allowed; boolean allowed;
boolean allowedWithConfirmation; boolean allowedWithConfirmation;
int size; int size;

2
gerrit-server/src/main/java/com/google/gerrit/server/account/AccountState.java
View File

@@ -35,7 +35,7 @@ import java.util.Map;
import java.util.Set; import java.util.Set;
public class AccountState { public class AccountState {
public static Function<AccountState, Account.Id> ACCOUNT_ID_FUNCTION = public static final Function<AccountState, Account.Id> ACCOUNT_ID_FUNCTION =
new Function<AccountState, Account.Id>() { new Function<AccountState, Account.Id>() {
@Override @Override
public Account.Id apply(AccountState in) { public Account.Id apply(AccountState in) {