diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/WebLinks.java b/gerrit-server/src/main/java/com/google/gerrit/server/WebLinks.java index d2e3e4911f..318f847dd8 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/WebLinks.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/WebLinks.java @@ -24,6 +24,7 @@ import com.google.gerrit.extensions.webui.ProjectWebLink; import com.google.inject.Inject; import com.google.inject.Singleton; +import java.util.ArrayList; import java.util.List; @Singleton @@ -45,8 +46,8 @@ public class WebLinks { this.branchLinks = branchLinks; } - public Iterable getPatchSetLinks(String project, String commit) { - List links = Lists.newArrayList(); + public List getPatchSetLinks(String project, String commit) { + List links = new ArrayList<>(4); for (PatchSetWebLink webLink : patchSetLinks) { links.add(new WebLinkInfo(webLink.getLinkName(), webLink.getImageUrl(), diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/change/ChangeJson.java b/gerrit-server/src/main/java/com/google/gerrit/server/change/ChangeJson.java index e6b36e5714..e91b23631f 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/change/ChangeJson.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/change/ChangeJson.java @@ -843,11 +843,9 @@ public class ChangeJson { } if (has(WEB_LINKS)) { - out.webLinks = Lists.newArrayList(); - for (WebLinkInfo link : webLinks.getPatchSetLinks( - project, in.getRevision().get())) { - out.webLinks.add(link); - } + List links = + webLinks.getPatchSetLinks(project, in.getRevision().get()); + out.webLinks = !links.isEmpty() ? links : null; } return out; }