opendev/gerrit
Code Issues Proposed changes

Actions: Respect enabled flag for core action buttons

Browse Source 
Only action buttons supplied by plugins respect enabled attribute in
action info.

Change-Id: I2a6f1011688ef2c68ddd437ec04502e8a54043c9
This commit is contained in:
David Ostrovsky 2015-01-24 08:06:25 +01:00 committed by Stefan Beller
parent 426f6d0a6d
commit 2c3d2523d9
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Actions.java
View File

@ -120,6 +120,7 @@ class Actions extends Composite {
if (canSubmit) {
ActionInfo action = actions.get("submit");
submit.setTitle(action.title());
submit.setEnabled(action.enabled());
submit.setHTML(new SafeHtmlBuilder()
.openDiv()
.append(action.label())
@ -201,7 +202,9 @@ class Actions extends Composite {
private static void a2b(NativeMap<ActionInfo> actions, String a, Button b) {
if (actions.containsKey(a)) {
b.setVisible(true);
b.setTitle(actions.get(a).title());
ActionInfo actionInfo = actions.get(a);
b.setTitle(actionInfo.title());
b.setEnabled(actionInfo.enabled());
}
}
}