opendev/gerrit
Code Issues Proposed changes

Show proper error message if registering email address fails

Browse Source 
Users can register new email address under 'Settings > Contact
Information'. If the registration fails, e.g. because the mail server
is incorrectly configured or because the mail server refuses to send
the email, an error dialog with 'Code Review - Error > Server Error >
[message]' is displayed which makes the user think that there is
something wrong with Gerrit. Slightly improve the error reporting by
setting a proper title for the error dialog and removing 'Server Error'
from the message.

Bug: issue 1480
Change-Id: I788e5bdf69aaaee17a1fd468f81d3effaa13a624
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
This commit is contained in:
Edwin Kempin
2013-01-03 14:47:06 +01:00
parent 6802493d7b
commit 2c75536a73
27 changed files with 41 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
gerrit-server/src/main/java/com/google/gerrit/server/mail/NewChangeSender.java
View File

@@ -14,6 +14,7 @@
package com.google.gerrit.server.mail;
import com.google.gerrit.common.errors.EmailException;
import com.google.gerrit.reviewdb.client.Account;
import com.google.gerrit.reviewdb.client.Change;
import com.google.gerrit.server.ssh.SshInfo;