Add configs for enabling attention set and assignee

Change-Id: Ie1d5757150726df145be9d64677d785abf845ea0
This commit is contained in:
Ben Rohlfs 2020-02-28 12:44:09 +01:00
parent 82033aaaaa
commit 2cc335450c
5 changed files with 27 additions and 0 deletions

View File

@ -1222,6 +1222,20 @@ If set to true, users are not allowed to create private changes.
+
The default is false.
[[change.enableAttentionSet]]change.enableAttentionSet::
+
If set to true, then all UI features for using and interacting with the
attention set are enabled.
+
The default is false for now, but will be changed to true in Q2 2020.
[[change.enableAssignee]]change.enableAssignee::
+
If set to true, then all UI features for using and interacting with the
assignee are enabled.
+
The default is true for now, but will be changed to false in Q2 2020.
[[change.largeChange]]change.largeChange::
+
Number of changed lines from which on a change is considered as a large

View File

@ -1574,6 +1574,10 @@ Value of the link:config-gerrit.html#change.mergeabilityComputationBehavior[
configuration parameter] that controls whether the mergeability bit in
link:rest-api-changes.html#change-info[ChangeInfo] will never be set and if the
bit is indexed.
|`enable_attention_set` |defaults to `false`|
Returns true if attention set UI features are enabled.
|`enable_assignee` |defaults to `true`|
Returns true if assignee related UI features are enabled.
|=============================
[[change-index-config-info]]

View File

@ -25,4 +25,6 @@ public class ChangeConfigInfo {
public int updateDelay;
public Boolean submitWholeTopic;
public String mergeabilityComputationBehavior;
public Boolean enableAttentionSet;
public Boolean enableAssignee;
}

View File

@ -237,6 +237,9 @@ public class GetServerInfo implements RestReadView<ConfigResource> {
toBoolean(this.config.getBoolean("change", null, "disablePrivateChanges", false));
info.mergeabilityComputationBehavior =
MergeabilityComputationBehavior.fromConfig(config).name();
info.enableAttentionSet =
toBoolean(this.config.getBoolean("change", null, "enableAttentionSet", false));
info.enableAssignee = toBoolean(this.config.getBoolean("change", null, "enableAssignee", true));
return info;
}

View File

@ -63,6 +63,8 @@ public class ServerInfoIT extends AbstractDaemonTest {
@GerritConfig(name = "change.replyLabel", value = "Vote")
@GerritConfig(name = "change.updateDelay", value = "50s")
@GerritConfig(name = "change.disablePrivateChanges", value = "true")
@GerritConfig(name = "change.enableAttentionSet", value = "true")
@GerritConfig(name = "change.enableAssignee", value = "true")
// download
@GerritConfig(
@ -105,6 +107,8 @@ public class ServerInfoIT extends AbstractDaemonTest {
assertThat(i.change.replyLabel).isEqualTo("Vote\u2026");
assertThat(i.change.updateDelay).isEqualTo(50);
assertThat(i.change.disablePrivateChanges).isTrue();
assertThat(i.change.enableAttentionSet).isTrue();
assertThat(i.change.enableAssignee).isTrue();
// download
assertThat(i.download.archives).containsExactly("tar", "tbz2", "tgz", "txz");