opendev/gerrit
Code Issues Proposed changes

SubmitStrategyFactory: Remove unnecessary finals

Browse Source 
Change-Id: If1f64f66f7a2a07a2196bff1160eb04ef52a2b0b
This commit is contained in:
Dave Borowitz
2015-12-10 13:15:12 -05:00
parent 81c3ad98e7
commit 2ccefd45fc
1 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
gerrit-server/src/main/java/com/google/gerrit/server/git/strategy/SubmitStrategyFactory.java
View File

@@ -62,13 +62,13 @@ public class SubmitStrategyFactory {
@Inject @Inject
SubmitStrategyFactory( SubmitStrategyFactory(
@GerritPersonIdent Provider<PersonIdent> myIdent, @GerritPersonIdent Provider<PersonIdent> myIdent,
final BatchUpdate.Factory batchUpdateFactory, BatchUpdate.Factory batchUpdateFactory,
final ChangeControl.GenericFactory changeControlFactory, ChangeControl.GenericFactory changeControlFactory,
final PatchSetInfoFactory patchSetInfoFactory, PatchSetInfoFactory patchSetInfoFactory,
final RebaseChangeOp.Factory rebaseFactory, RebaseChangeOp.Factory rebaseFactory,
final ProjectCache projectCache, ProjectCache projectCache,
final ApprovalsUtil approvalsUtil, ApprovalsUtil approvalsUtil,
final MergeUtil.Factory mergeUtilFactory) { MergeUtil.Factory mergeUtilFactory) {
this.myIdent = myIdent; this.myIdent = myIdent;
this.batchUpdateFactory = batchUpdateFactory; this.batchUpdateFactory = batchUpdateFactory;
this.changeControlFactory = changeControlFactory; this.changeControlFactory = changeControlFactory;
@@ -101,7 +101,7 @@ public class SubmitStrategyFactory {
case REBASE_IF_NECESSARY: case REBASE_IF_NECESSARY:
return new RebaseIfNecessary(args, patchSetInfoFactory, rebaseFactory); return new RebaseIfNecessary(args, patchSetInfoFactory, rebaseFactory);
default: default:
final String errorMsg = "No submit strategy for: " + submitType; String errorMsg = "No submit strategy for: " + submitType;
log.error(errorMsg); log.error(errorMsg);
throw new IntegrationException(errorMsg); throw new IntegrationException(errorMsg);
} }
@@ -109,7 +109,7 @@ public class SubmitStrategyFactory {
private ProjectState getProject(Branch.NameKey branch) private ProjectState getProject(Branch.NameKey branch)
throws NoSuchProjectException { throws NoSuchProjectException {
final ProjectState p = projectCache.get(branch.getParentKey()); ProjectState p = projectCache.get(branch.getParentKey());
if (p == null) { if (p == null) {
throw new NoSuchProjectException(branch.getParentKey()); throw new NoSuchProjectException(branch.getParentKey());
} }