opendev/gerrit
Code Issues Proposed changes

Make IdentifiedUser.clearStarredChanges return void

Browse Source 
This method was always returning null. Easier to declare it returns
void instead of a Set<Change.Id> that is always null. Fortunately no
caller used the return value.

Change-Id: I198e0841cf2e9f07e2995700987518c1b99ac6f4
This commit is contained in:
Shawn Pearce
2015-04-02 12:13:28 -07:00
parent 4502ac8d35
commit 2d0362f1b6
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
gerrit-server/src/main/java/com/google/gerrit/server/IdentifiedUser.java
View File

@@ -341,12 +341,11 @@ public class IdentifiedUser extends CurrentUser {
return starredChanges; return starredChanges;
} }
public Set<Change.Id> clearStarredChanges() { public void clearStarredChanges() {
// Async query may have started before an update that the caller expects // Async query may have started before an update that the caller expects
// to see the results of, so we can't trust it. // to see the results of, so we can't trust it.
abortStarredChanges(); abortStarredChanges();
starredChanges = null; starredChanges = null;
return starredChanges;
} }
public void asyncStarredChanges() { public void asyncStarredChanges() {