opendev/gerrit
Code Issues Proposed changes

Fix approval table to show votes for labels satisfied by submit_rule.

Browse Source 
Since d42555ae01 the ApprovalTable
wouldn't show a vote computed by the submit_rule from rules.pl.
If, for example, we require a Non-Author-Code-Review and it is met
by a Code-Review+2 vote from a non-author then the ApprovalTable
wouldn't show the green check for the Non-Author-Code-Review label
in the row showing votes for that user.

Change-Id: I3fdc56308197812133f283bcca997885a5fde513
Signed-off-by: Sasa Zivkov <sasa.zivkov@sap.com>
This commit is contained in:
Sasa Zivkov
2012-09-24 15:42:09 +02:00
parent eb081dcfbf
commit 2d17e2b22c
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ApprovalTable.java
View File

@@ -400,8 +400,9 @@ public class ApprovalTable extends Composite {
if (!ad.canVote(labelName)) { if (!ad.canVote(labelName)) {
fmt.addStyleName(row, col, Gerrit.RESOURCES.css().notVotable()); fmt.addStyleName(row, col, Gerrit.RESOURCES.css().notVotable());
fmt.getElement(row, col).setTitle(Gerrit.C.userCannotVoteToolTip()); fmt.getElement(row, col).setTitle(Gerrit.C.userCannotVoteToolTip());
}
} else if (ad.isRejected(labelName)) { if (ad.isRejected(labelName)) {
table.setWidget(row, col, new Image(Gerrit.RESOURCES.redNot())); table.setWidget(row, col, new Image(Gerrit.RESOURCES.redNot()));
} else if (ad.isApproved(labelName)) { } else if (ad.isApproved(labelName)) {