opendev/gerrit
Code Issues Proposed changes

Create enum containing all Gerrit top menu items

Browse Source 
Instead of relying on string names for Gerrit's top menu items,
provide an enumeration that contains definitions of all top items.

It also adds GWT Extensions module to fulfill compilation dependency
for gwtui.

Change-Id: I7a109885b9a65b132e7119851cd76be527f75364
Signed-off-by: Dariusz Luksza <dariusz@luksza.org>
This commit is contained in:
Dariusz Luksza
2013-10-01 11:07:13 +02:00
committed by Shawn Pearce
parent a5c3ef93ab
commit 2d3afab63f
8 changed files with 70 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
gerrit-extension-api/src/main/java/com/google/gerrit/extensions/webui/TopMenu.java
View File

@@ -20,11 +20,14 @@ import java.util.List;
@ExtensionPoint
public interface TopMenu {
public class MenuEntry {
public final String name;
public final List<MenuItem> items;
public MenuEntry(GerritTopMenu gerritMenu, List<MenuItem> items) {
this(gerritMenu.menuName, items);
}
public MenuEntry(String name, List<MenuItem> items) {
this.name = name;
this.items = items;