opendev/gerrit
Code Issues Proposed changes

Change CopyableLabel to hide onKeyUp

Browse Source 
This changes the CopyableLabel to hide itself onKeyUp, after a
copy, since hiding onKeyPress would hide the text box before Safari
had a chance to copy it.  Ultimately, the effect is the same, it
just delays the processing a little further on.

Bug: Issue 2635
Change-Id: I06a25b81c1da7286a09561732510fe4d6835a2a7
This commit is contained in:
Doug Kelly
2014-05-12 16:59:11 -05:00
committed by Doug Kelly
parent 0e9cff85b8
commit 2d68f32f21
1 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
gerrit-gwtexpui/src/main/java/com/google/gwtexpui/clippy/client/CopyableLabel.java
View File

@@ -22,6 +22,8 @@ import com.google.gwt.event.dom.client.ClickEvent;
import com.google.gwt.event.dom.client.ClickHandler; import com.google.gwt.event.dom.client.ClickHandler;
import com.google.gwt.event.dom.client.KeyPressEvent; import com.google.gwt.event.dom.client.KeyPressEvent;
import com.google.gwt.event.dom.client.KeyPressHandler; import com.google.gwt.event.dom.client.KeyPressHandler;
import com.google.gwt.event.dom.client.KeyUpEvent;
import com.google.gwt.event.dom.client.KeyUpHandler;
import com.google.gwt.http.client.URL; import com.google.gwt.http.client.URL;
import com.google.gwt.user.client.Command; import com.google.gwt.user.client.Command;
import com.google.gwt.user.client.DOM; import com.google.gwt.user.client.DOM;
@@ -189,9 +191,14 @@ public class CopyableLabel extends Composite implements HasText {
switch (event.getCharCode()) { switch (event.getCharCode()) {
case 'c': case 'c':
case 'x': case 'x':
Scheduler.get().scheduleDeferred(new Command() { textBox.addKeyUpHandler(new KeyUpHandler() {
public void execute() { @Override
hideTextBox(); public void onKeyUp(final KeyUpEvent event) {
Scheduler.get().scheduleDeferred(new Command() {
public void execute() {
hideTextBox();
}
});
} }
}); });
break; break;