opendev/gerrit
Code Issues Proposed changes

Support JSON for plugin list command

Browse Source 
Move the plugin list command implementation to the server, so it can
be used from HTTP. Add a format option.

Signed-off-by: Brad Larson <bklarson@gmail.com>
Change-Id: Ie0621d78eb0f3f0fbd37e9fb42452f027ab7c349
This commit is contained in:
Brad Larson
2012-05-15 15:38:27 -05:00
parent 5cc8f6647b
commit 2d872ebff2
2 changed files with 119 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/PluginLsCommand.java
View File

@@ -14,39 +14,29 @@
package com.google.gerrit.sshd.commands;
import com.google.common.base.Strings;
import com.google.common.collect.Lists;
import com.google.gerrit.common.data.GlobalCapability;
import com.google.gerrit.server.plugins.Plugin;
import com.google.gerrit.server.plugins.PluginLoader;
import com.google.gerrit.server.plugins.ListPlugins;
import com.google.gerrit.sshd.BaseCommand;
import com.google.gerrit.sshd.RequiresCapability;
import com.google.gerrit.sshd.SshCommand;
import com.google.inject.Inject;
import java.util.Collections;
import java.util.Comparator;
import java.util.List;
import org.apache.sshd.server.Environment;
import java.io.IOException;
@RequiresCapability(GlobalCapability.ADMINISTRATE_SERVER)
final class PluginLsCommand extends SshCommand {
final class PluginLsCommand extends BaseCommand {
@Inject
private PluginLoader loader;
private ListPlugins impl;
@Override
protected void run() {
List<Plugin> running = Lists.newArrayList(loader.getPlugins());
Collections.sort(running, new Comparator<Plugin>() {
public void start(Environment env) throws IOException {
startThread(new CommandRunnable() {
@Override
public int compare(Plugin a, Plugin b) {
return a.getName().compareTo(b.getName());
public void run() throws Exception {
parseCommandLine(impl);
impl.display(out);
}
});
stdout.format("%-30s %-10s\n", "Name", "Version");
stdout.print("----------------------------------------------------------------------\n");
for (Plugin p : running) {
stdout.format("%-30s %-10s\n", p.getName(),
Strings.nullToEmpty(p.getVersion()));
}
}
}