opendev/gerrit
Code Issues Proposed changes

Remove group type from AccountGroupInfoScreen

Browse Source 
The information about the group type was not much helpful. All groups
that can be seen in Gerrit are of type 'INTERNAL', except a few
well-known system groups which are of type 'SYSTEM'. The system groups
are so well-known that there is no need to display the type for them.

Especially the type selection box was pretty pointless as you could
only choose 'INTERNAL' as type.

This change also removes the RPC for changing the group type as it is
not needed anymore.

Change-Id: I16d5a8056d0993bcdd810b76ab8379c67f475a6a
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
This commit is contained in:
Edwin Kempin
2013-01-30 15:41:50 +01:00
parent f2ed5a5c9b
commit 2dcd22ce85
7 changed files with 1 additions and 134 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
gerrit-common/src/main/java/com/google/gerrit/common/data/GroupAdminService.java
View File

@@ -53,11 +53,6 @@ public interface GroupAdminService extends RemoteJsonService {
void renameGroup(AccountGroup.Id groupId, String newName,
AsyncCallback<GroupDetail> callback);
@Audit
@SignInRequired
void changeGroupType(AccountGroup.Id groupId, AccountGroup.Type newType,
AsyncCallback<VoidResult> callback);
@Audit
@SignInRequired
void addGroupInclude(AccountGroup.Id groupId, AccountGroup.UUID incGroupUUID,