opendev/gerrit
Code Issues Proposed changes

Clean up missing final in Binder declarations

Browse Source 
Change-Id: Ic9b4bbb37e142885bfbd4c696d28eb9a8442415e
This commit is contained in:
David Ostrovsky
2013-08-25 06:50:19 +02:00
parent 2de365c05f
commit 2dd0bf9c60
17 changed files with 17 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ActionMessageBox.java
View File

@@ -34,7 +34,7 @@ import com.google.gwtexpui.user.client.PluginSafePopupPanel;
abstract class ActionMessageBox extends Composite {
interface Binder extends UiBinder<HTMLPanel, ActionMessageBox> {}
private static Binder uiBinder = GWT.create(Binder.class);
private static final Binder uiBinder = GWT.create(Binder.class);
static interface Style extends CssResource {
String popup();

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Actions.java
View File

@@ -38,7 +38,7 @@ class Actions extends Composite {
"cherrypick", "submit", "rebase", "message"};
interface Binder extends UiBinder<FlowPanel, Actions> {}
private static Binder uiBinder = GWT.create(Binder.class);
private static final Binder uiBinder = GWT.create(Binder.class);
@UiField Button cherrypick;
@UiField Button rebase;

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ChangeScreen2.java
View File

@@ -92,7 +92,7 @@ import java.util.Map;
public class ChangeScreen2 extends Screen {
interface Binder extends UiBinder<HTMLPanel, ChangeScreen2> {}
private static Binder uiBinder = GWT.create(Binder.class);
private static final Binder uiBinder = GWT.create(Binder.class);
interface Style extends CssResource {
String labelName();

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/CommitBox.java
View File

@@ -34,7 +34,7 @@ import com.google.gwtexpui.safehtml.client.SafeHtmlBuilder;
class CommitBox extends Composite {
interface Binder extends UiBinder<HTMLPanel, CommitBox> {}
private static Binder uiBinder = GWT.create(Binder.class);
private static final Binder uiBinder = GWT.create(Binder.class);
@UiField Element commitName;
@UiField AnchorElement browserLink;

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Message.java
View File

@@ -34,7 +34,7 @@ import com.google.gwtexpui.safehtml.client.SafeHtmlBuilder;
class Message extends Composite {
interface Binder extends UiBinder<HTMLPanel, Message> {}
private static Binder uiBinder = GWT.create(Binder.class);
private static final Binder uiBinder = GWT.create(Binder.class);
static interface Style extends CssResource {
String closed();

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RelatedChanges.java
View File

@@ -48,7 +48,7 @@ import com.google.gwtexpui.safehtml.client.SafeHtmlBuilder;
class RelatedChanges extends Composite {
interface Binder extends UiBinder<HTMLPanel, RelatedChanges> {}
private static Binder uiBinder = GWT.create(Binder.class);
private static final Binder uiBinder = GWT.create(Binder.class);
private static final String OPEN;
private static final HyperlinkImpl link = GWT.create(HyperlinkImpl.class);

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ReplyBox.java
View File

@@ -57,7 +57,7 @@ import java.util.TreeSet;
class ReplyBox extends Composite {
interface Binder extends UiBinder<HTMLPanel, ReplyBox> {}
private static Binder uiBinder = GWT.create(Binder.class);
private static final Binder uiBinder = GWT.create(Binder.class);
interface Styles extends CssResource {
String label_name();

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Topic.java
View File

@@ -42,7 +42,7 @@ import com.google.gwtexpui.globalkey.client.NpTextBox;
/** Displays (and edits) the change topic string. */
class Topic extends Composite {
interface Binder extends UiBinder<HTMLPanel, Topic> {}
private static Binder uiBinder = GWT.create(Binder.class);
private static final Binder uiBinder = GWT.create(Binder.class);
private PatchSet.Id psId;
private boolean canEdit;

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/UpdateAvailableBar.java
View File

@@ -41,7 +41,7 @@ import java.util.List;
/** Displays the "New Message From ..." panel in bottom right on updates. */
abstract class UpdateAvailableBar extends PopupPanel {
interface Binder extends UiBinder<HTMLPanel, UpdateAvailableBar> {}
private static Binder uiBinder = GWT.create(Binder.class);
private static final Binder uiBinder = GWT.create(Binder.class);
static interface Style extends CssResource {
String popup();

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/CommitMessageBlock.java
View File

@@ -46,7 +46,7 @@ public class CommitMessageBlock extends Composite {
interface Binder extends UiBinder<HTMLPanel, CommitMessageBlock> {
}
private static Binder uiBinder = GWT.create(Binder.class);
private static final Binder uiBinder = GWT.create(Binder.class);
private KeyCommandSet keysAction;

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/DiffTable.java
View File

@@ -33,7 +33,7 @@ import com.google.gwt.user.client.ui.Widget;
*/
class DiffTable extends Composite {
interface Binder extends UiBinder<HTMLPanel, DiffTable> {}
private static Binder uiBinder = GWT.create(Binder.class);
private static final Binder uiBinder = GWT.create(Binder.class);
interface DiffTableStyle extends CssResource {
String intralineBg();

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/DraftBox.java
View File

@@ -52,7 +52,7 @@ import net.codemirror.lib.CodeMirror;
/** An HtmlPanel for displaying and editing a draft */
class DraftBox extends CommentBox {
interface Binder extends UiBinder<HTMLPanel, DraftBox> {}
private static Binder uiBinder = GWT.create(Binder.class);
private static final Binder uiBinder = GWT.create(Binder.class);
private static final int INITIAL_LINES = 5;
private static final int MAX_LINES = 30;

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/PublishedBox.java
View File

@@ -44,7 +44,7 @@ import net.codemirror.lib.CodeMirror;
/** An HtmlPanel for displaying a published comment */
class PublishedBox extends CommentBox {
interface Binder extends UiBinder<HTMLPanel, PublishedBox> {}
private static Binder uiBinder = GWT.create(Binder.class);
private static final Binder uiBinder = GWT.create(Binder.class);
static interface Style extends CssResource {
String closed();

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/SideBySide2.java
View File

@@ -98,7 +98,7 @@ import java.util.Map;
public class SideBySide2 extends Screen {
interface Binder extends UiBinder<FlowPanel, SideBySide2> {}
private static Binder uiBinder = GWT.create(Binder.class);
private static final Binder uiBinder = GWT.create(Binder.class);
private static final JsArrayString EMPTY =
JavaScriptObject.createArray().cast();

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/SidePanel.java
View File

@@ -37,7 +37,7 @@ import java.util.List;
/** The Widget that handles the scrollbar gutters */
class SidePanel extends Composite {
interface Binder extends UiBinder<HTMLPanel, SidePanel> {}
private static Binder uiBinder = GWT.create(Binder.class);
private static final Binder uiBinder = GWT.create(Binder.class);
interface SidePanelStyle extends CssResource {
String gutter();

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/SkipBar.java
View File

@@ -39,7 +39,7 @@ import net.codemirror.lib.TextMarker.FromTo;
/** The Widget that handles expanding of skipped lines */
class SkipBar extends Composite {
interface Binder extends UiBinder<HTMLPanel, SkipBar> {}
private static Binder uiBinder = GWT.create(Binder.class);
private static final Binder uiBinder = GWT.create(Binder.class);
private static final int NUM_ROWS_TO_EXPAND = 10;
private static final int UP_DOWN_THRESHOLD = 30;
private static final Configuration COLLAPSED =

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/PatchSetSelectBox.java
View File

@@ -44,7 +44,7 @@ public class PatchSetSelectBox extends Composite {
interface Binder extends UiBinder<HTMLPanel, PatchSetSelectBox> {
}
private static Binder uiBinder = GWT.create(Binder.class);
private static final Binder uiBinder = GWT.create(Binder.class);
interface BoxStyle extends CssResource {
String selected();