opendev/gerrit
Code Issues Proposed changes

Revert "ChangeScreen2: Auto-focus to submit button"

Browse Source 
This reverts commit ba41a83819.

Users do not like the auto-focus on submit. The button is too
dangerous to be clicked because code might actually land into
the project after being reviewed and approved.

Change-Id: Ia60b22b4e8f0fd607f44657572b4c7dabdb73352
This commit is contained in:
Shawn Pearce
2013-12-13 11:41:17 -08:00
parent beb4d61187
commit 2df7278a9f
6 changed files with 8 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gerrit-gwtui/src/main/java/com/google/gerrit/client/Dispatcher.java
View File

@@ -493,7 +493,7 @@ public class Dispatcher {
if (rest.isEmpty()) {
Gerrit.display(token, panel== null
? (isChangeScreen2()
? new ChangeScreen2(id, null, null, false, false)
? new ChangeScreen2(id, null, null, false)
: new ChangeScreen(id))
: new NotFoundScreen());
return;
@@ -530,7 +530,7 @@ public class Dispatcher {
base != null
? String.valueOf(base.get())
: null,
String.valueOf(ps.get()), false, false)
String.valueOf(ps.get()), false)
: new ChangeScreen(id));
} else if ("publish".equals(panel)) {
publish(ps);