opendev/gerrit
Code Issues Proposed changes

Remove unnecessary group visibility check from ListMembers

Browse Source 
As input to ListMembers we're getting a GroupResource and on creation
of the GroupResource in GroupsCollection it is already verified that
the current user is owner of the group. There is no need to check the
visibility again.

Change-Id: I0ac359c0aa386d88c8f2878e6fff51e470590a4a
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
This commit is contained in:
Edwin Kempin
2013-01-16 15:21:32 +01:00
parent 6b1a7dbf19
commit 2e0c360470
1 changed files with 2 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
gerrit-server/src/main/java/com/google/gerrit/server/group/ListMembers.java
View File

@@ -25,7 +25,6 @@ import com.google.gerrit.reviewdb.client.AccountGroup;
import com.google.gerrit.reviewdb.client.AccountGroupMember;
import com.google.gerrit.server.account.AccountCache;
import com.google.gerrit.server.account.GroupCache;
import com.google.gerrit.server.account.GroupControl;
import com.google.gerrit.server.account.GroupDetailFactory;
import com.google.gerrit.server.group.MembersCollection.MemberInfo;
import com.google.inject.Inject;
@@ -33,17 +32,14 @@ import com.google.inject.Inject;
import java.util.List;
public class ListMembers implements RestReadView<GroupResource> {
private final GroupControl.Factory groupControlFactory;
private final GroupCache groupCache;
private final GroupDetailFactory.Factory groupDetailFactory;
private final AccountCache accountCache;
@Inject
ListMembers(final GroupControl.Factory groupControlFactory,
final GroupCache groupCache,
ListMembers(final GroupCache groupCache,
final GroupDetailFactory.Factory groupDetailFactory,
final AccountCache accountCache) {
this.groupControlFactory = groupControlFactory;
this.groupCache = groupCache;
this.groupDetailFactory = groupDetailFactory;
this.accountCache = accountCache;
@@ -54,10 +50,8 @@ public class ListMembers implements RestReadView<GroupResource> {
BadRequestException, ResourceConflictException, Exception {
final List<MemberInfo> members = Lists.newArrayList();
final GroupControl groupControl =
groupControlFactory.validateFor(resource.getGroupUUID());
final AccountGroup group =
groupCache.get(groupControl.getGroup().getGroupUUID());
groupCache.get(resource.getGroupUUID());
final GroupDetail groupDetail =
groupDetailFactory.create(group.getId()).call();